optimize: using namespace from command line when deployment with helm charts

[baiyangtx]

• I have registered the PR changes.

Ⅰ. Describe what this PR did

1. Currently, the namespace set in Values.yaml only takes effect for deployment-type resources, while service and pod resources ignore this value.
2. It is customary to specify the namespace using the -n parameter in the helm install command, but currently, deployment ignores the namespace specified in the command line.

so in this PR:

1. The configuration for namespace has been removed from values.yaml.
2. When creating all Kubernetes resources, specify the value to use for the namespace as {{ .Release.Namespace }}.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

I confirmed the correctness of the execution result through helm template --dry-run.

Ⅳ. Describe how to verify it

Install with -n

$ helm template --dry-run instance  -n middleware   ./seata-server 
---
# Source: seata-server/templates/service.yaml
apiVersion: v1
kind: Service
metadata:
  namespace: "middleware"
  name: instance-seata-server
  labels:
    app.kubernetes.io/name: seata-server
    helm.sh/chart: seata-server-1.0.0
    app.kubernetes.io/instance: instance
    app.kubernetes.io/version: "1.0"
    app.kubernetes.io/managed-by: Helm
spec:
  type: NodePort
  ports:
    - port: 30091
      targetPort: http
      protocol: TCP
      name: http
  selector:
    app.kubernetes.io/name: seata-server
    app.kubernetes.io/instance: instance

Install without -n

$ helm template --dry-run instance    ./seata-server 
---
# Source: seata-server/templates/service.yaml
apiVersion: v1
kind: Service
metadata:
  namespace: "default"
  name: instance-seata-server
  labels:
    app.kubernetes.io/name: seata-server
    helm.sh/chart: seata-server-1.0.0
    app.kubernetes.io/instance: instance
    app.kubernetes.io/version: "1.0"
    app.kubernetes.io/managed-by: Helm
spec:
  type: NodePort
  ports:
    - port: 30091
      targetPort: http
      protocol: TCP
      name: http
  selector:
    app.kubernetes.io/name: seata-server
    app.kubernetes.io/instance: instance

Ⅴ. Special notes for reviews

[baiyangtx]

@leizhiyuan

This is the resubmitted PR of #6029

[baiyangtx]

Hello, @funky-eyes I hope you're doing well! Just a friendly reminder that my submitted PR is still awaiting merge. If you have some time, please merge it as soon as possible. Thank you so much for your assistance and patience!

[codecov]

Codecov Report

Merging #6034 (ec5b113) into 2.x (986fc81) will decrease coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

@@             Coverage Diff              @@
##                2.x    #6034      +/-   ##
============================================
- Coverage     49.43%   49.39%   -0.05%     
+ Complexity     4810     4804       -6     
============================================
  Files           913      913              
  Lines         31678    31678              
  Branches       3826     3826              
============================================
- Hits          15661    15647      -14     
- Misses        14477    14484       +7     
- Partials       1540     1547       +7     

see 4 files with indirect coverage changes

[funky-eyes]

Why remove it?

[baiyangtx]

We can apply namespace with command args

helm install instance  -n ${namespace}   ./seata-server 

[funky-eyes]

We can apply namespace with command args

helm install instance  -n ${namespace}   ./seata-server 

ok

[funky-eyes]

Please register the author and PR information in the 2.xmd file under the changes folder.

[xingfudeshi]

Please register the author and PR information in the 2.xmd file under the changes folder.

Done.It's ready to merge.

[xingfudeshi]

LGTM.