Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GET return no error when key type is not string #1970

Closed
wants to merge 1 commit into from

Conversation

jihuayu
Copy link
Member

@jihuayu jihuayu commented Dec 25, 2023

fixed #1969

Copy link

sonarcloud bot commented Dec 25, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@git-hulk
Copy link
Member

@jihuayu Could you add a test case to make sure this issue was resolved?

@jihuayu
Copy link
Member Author

jihuayu commented Dec 25, 2023

@git-hulk No problem, I will add test cases for each type.

@git-hulk
Copy link
Member

@git-hulk No problem, I will add test cases for each type.

Thank you!

@git-hulk
Copy link
Member

@jihuayu This bug should be resolved after #1971, but can add test cases to make sure it works well if you like.

@jihuayu
Copy link
Member Author

jihuayu commented Dec 27, 2023

@git-hulk All right, I'm a bit busy these days, I will come back later to solve it.

@jihuayu
Copy link
Member Author

jihuayu commented Jan 2, 2024

Many commands have this kind of constraint (cannot operate on keys of other types), and we may need a universal method to test them.
I will find a better way that covers this issue.
Close this PR.

@jihuayu jihuayu closed this Jan 2, 2024
@jihuayu jihuayu deleted the f/1225-get branch January 2, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using GET to get json type key will not return error.
2 participants