Record and export the keyspace hit/miss count to INFO command #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Redis supports to inspect the keyspace hit/miss count via INFO command to see if the hit ratio is expected. So we also export the same metric to align with Redis metrics.
git-hulk
force-pushed
the
feature/add-keyspace-stat
branch
from
27f7000
to
dad4409
Compare
|
torwig
approved these changes
Dec 26, 2023
mapleFU
reviewed
Dec 27, 2023
| db_stats_.compaction_count += v; | ||
| break; | ||
| case StatType::KeyspaceHits: | ||
| db_stats_.keyspace_hits += v; |
There was a problem hiding this comment.
Would fetch_add(relaxed) better, which might not need to hold the execution pipeline?
There was a problem hiding this comment.
@mapleFU Yes, it don't require strict sequence increase.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Redis supports inspecting the keyspace hit/miss count via
INFO command to see if the hit ratio is expected. So we also export
the same metric to align with Redis metrics.
This closes #1937