Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the RESP3 boolean type #1991

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented Jan 6, 2024

This closes #1981

We also implement the DEBUG PROTOCOL [type] for testing the RESP3 new
types. And add a new configuration resp3-enabled to enable the RESP3
for testing purposes.

@git-hulk git-hulk marked this pull request as draft January 6, 2024 14:15
@git-hulk git-hulk force-pushed the add-resp3-bool branch 2 times, most recently from 8d99c24 to fa7e86f Compare January 6, 2024 14:33
We also implement the DEBUG PROTOCOL [type] for testing the RESP3 new
types. And add a new configuration `resp3-enabled` to enable the RESP3
for testing purpose.
Copy link

sonarcloud bot commented Jan 6, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

sonarcloud bot commented Jan 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
1.9% Duplication on New Code

See analysis details on SonarCloud

@git-hulk git-hulk marked this pull request as ready for review January 6, 2024 15:09
@git-hulk git-hulk requested review from PragmaTwice, mapleFU, torwig and enjoy-binbin and removed request for PragmaTwice, mapleFU and torwig January 6, 2024 15:35
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@git-hulk git-hulk merged commit 6e79fa9 into apache:unstable Jan 8, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RESP3 boolean type
2 participants