-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of lua function 'redis.setresp()' #2130
Merged
git-hulk
merged 6 commits into
apache:unstable
from
git-hulk:feature/lua-setresp-function
Mar 1, 2024
Merged
Add support of lua function 'redis.setresp()' #2130
git-hulk
merged 6 commits into
apache:unstable
from
git-hulk:feature/lua-setresp-function
Mar 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
force-pushed
the
feature/lua-setresp-function
branch
from
February 29, 2024 15:08
dac7375
to
cbf1369
Compare
git-hulk
force-pushed
the
feature/lua-setresp-function
branch
from
February 29, 2024 15:11
cbf1369
to
d209641
Compare
enjoy-binbin
reviewed
Mar 1, 2024
git-hulk
changed the title
Add support of lua function 'redis.resp()'
Add support of lua function 'redis.setresp()'
Mar 1, 2024
enjoy-binbin
previously approved these changes
Mar 1, 2024
torwig
previously approved these changes
Mar 1, 2024
enjoy-binbin
approved these changes
Mar 1, 2024
torwig
approved these changes
Mar 1, 2024
Quality Gate failedFailed conditions |
Thanks for your review. @enjoy-binbin @torwig |
caipengbo
pushed a commit
that referenced
this pull request
Mar 3, 2024
Except for the `redis.setresp` function, it fixes the different behavior with Redis in Lua script. Before applying this PR, the Lua script will return the result in RESP3 format if the connection is connected with `HELLO 3` command. But for Redis, it will always use RESP2 unless users explicitly set it with `redis.setresp(3)`. ``` // Kvrocks ❯ redis-cli -3 -p 6666 127.0.0.1:6666> EVAL 'return redis.call("hgetall","hash")' 0 1# "f1" => "v1" // Redis ❯ redis-cli -3 127.0.0.1:6379> EVAL 'return redis.call("hgetall","hash")' 0 1) "f1" 2) "v1" ``` After applying this PR, it will behaves consistently with Redis: ``` ❯ redis-cli -3 -p 6666 127.0.0.1:6666> EVAL 'redis.setresp(3);return redis.call("hgetall","hash")' 0 1# "f1" => "v1" 127.0.0.1:6666> EVAL 'return redis.call("hgetall","hash")' 0 1) "f1" 2) "v1" ``` Co-authored-by: Binbin <[email protected]>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Except for the
redis.setresp
function, it fixes the different behavior with Redis in Lua script.Before applying this PR, the Lua script will return the result in RESP3 format
if the connection is connected with
HELLO 3
command. But for Redis,it will always use RESP2 unless users explicitly set it with
redis.setresp(3)
.After applying this PR, it will behaves consistently with Redis: