[MNG-7374] Mutating RelocatedArtifact does not retain type

[michael-o]

This closes #641

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace MNG-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[Marcono1234]

Could this be simplified?

Suggested change

	if ( current.equals( version ) || ( version == null && current.length() <= 0 ) )
	if ( current.equals( version ) || ( version == null && current.isEmpty() ) )

[michael-o]

While this is true, I wanted to retain the same code block as in AbstractArtifact for consistency reasons

[hboutemy]

@michael-o instead of copy/pasting the 3 methods, I think we could change "private Artifact newInstance" (from AbstractArtifact) to protected, then simply override this method

[michael-o]

@michael-o instead of copy/pasting the 3 methods, I think we could change "private Artifact newInstance" (from AbstractArtifact) to protected, then simply override this method

While you are absolutely right, this is not the target of this ticket OR I need to broaden the ticket and solve this for all derved types. I absolutely do not like the fact that AbstractArtifact lacks abstraction and uses DefaultArtifact internally.

Maybe: Mutating derived Artifact does not retain type

[hboutemy]

no, I'm not trying to automagically retain the original type: I'm just trying to use the (hand-written) factory to remove code duplication

digging a little bit more, it requires a maven-resolver release, which makes the update harder from a release perspective

[michael-o]

no, I'm not trying to automagically retain the original type: I'm just trying to use the (hand-written) factory to remove code duplication

Agree, suboptimal.

digging a little bit more, it requires a maven-resolver release, which makes the update harder from a release perspective

I guess we can make that for 2.0.0 happen. Maybe 1.8.0, unsure. @cstamas

[michael-o]

@hboutemy Any objections to merge this one and resolve in general with new issues?

[michael-o]

https://issues.apache.org/jira/browse/MRESOLVER-233

[hboutemy]

@michael-o no problem to do the work in 2 steps, sure