Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNG-5561] Plugin relocation loses configuration #642

Closed
wants to merge 1 commit into from
Closed

[MNG-5561] Plugin relocation loses configuration #642

wants to merge 1 commit into from

Conversation

michael-o
Copy link
Member

@michael-o michael-o commented Dec 25, 2021 •
edited
Loading

@michael-o michael-o marked this pull request as draft December 25, 2021 15:58
asfgit pushed a commit that referenced this pull request Dec 25, 2021
@michael-o
[MNG-5561] Plugin relocation loses configuration
3f03c4c 
Previously, to locate plugin configuration in a project the plugin descriptor
was read first and then the GA were extracted. This always worked because the
GA from the model and the GA from plugin descriptor (plugin.xml) were identical.
When a plugin is relocated the target artifact is read, thus its plugin
descriptor as well. Naturally, the GA of new (relocated) does not correspond to
the old (static) one in the model. Therefore, the configuration is not found.
New approach is to use the original plugin GA to locate the configuration in
the model regardless of the relocation.

This closes #642
@michael-o michael-o marked this pull request as ready for review December 25, 2021 23:18
asfgit pushed a commit that referenced this pull request Dec 30, 2021
@michael-o
[MNG-5561] Plugin relocation loses configuration
48339b9 
Previously, to locate plugin configuration in a project the plugin descriptor
was read first and then the GA were extracted. This always worked because the
GA from the model and the GA from plugin descriptor (plugin.xml) were identical.
When a plugin is relocated the target artifact is read, thus its plugin
descriptor as well. Naturally, the GA of new (relocated) does not correspond to
the old (static) one in the model. Therefore, the configuration is not found.
New approach is to use the original plugin GA to locate the configuration in
the model regardless of the relocation.

This closes #642
@michael-o
[MNG-5561] Plugin relocation loses configuration
05b748f 
Previously, to locate plugin configuration in the project the plugin descriptor
was read and the GA were extracted. This always worked because the GA from the
model and the GA from plugin descriptor (plugin.xml) were identical. When a
plugin is relocated the target artifact is read, thus its plugin descriptor as
well. Naturally, the GA of new (relocated) does not correspond to the old
(static) one in the model. Therefore, the configuration is not found.
New approach is to use the original plugin GA to locate the configuration in
the model regardless of relocation.
@asfgit asfgit closed this in 2670c00 Jan 6, 2022
@michael-o michael-o deleted the MNG-5561_maven-3.8.x branch January 6, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthmulders mthmulders mthmulders approved these changes

@cstamas cstamas cstamas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-o @cstamas @mthmulders