Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump rocksdb to resolve dependency conflicts with magnus #1713

Merged
merged 5 commits into from
Mar 21, 2023

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Mar 21, 2023

bump rocksdb to 0.18.0 , librocksdb-sys to 0.6.1(+6.28.2)

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks a lot.

@Xuanwo
Copy link
Member

Xuanwo commented Mar 21, 2023

But I'm bit worried about can it works on ubuntu 22.04 with installed librocksdb-dev. Can you trigger a rocksdb integration test?

Signed-off-by: Chojan Shang <[email protected]>
@Xuanwo
Copy link
Member

Xuanwo commented Mar 21, 2023

Hi, @PsiACE, sorry for the CI broken. Please merge main branch and try again.

@Xuanwo
Copy link
Member

Xuanwo commented Mar 21, 2023

Let me take a look.

Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo merged commit d5c7131 into apache:main Mar 21, 2023
@PsiACE PsiACE deleted the bump-rocksdb branch March 21, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants