Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services/azblob): Rewrite the method signatures using OpWrite #3068

Merged
merged 2 commits into from
Sep 14, 2023
Merged

feat(services/azblob): Rewrite the method signatures using OpWrite #3068

merged 2 commits into from
Sep 14, 2023

Conversation

acehinnnqru
Copy link
Contributor

Respect issue: #3064 .

Rewrote the service azblob.

@acehinnnqru acehinnnqru changed the title feat(services/azblob): Rewrite the method signatures using OpWrite feat(services/azblob)!: Rewrite the method signatures using OpWrite Sep 14, 2023
Xuanwo
Xuanwo reviewed Sep 14, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM, thanks a lot!

core/src/services/azblob/backend.rs Outdated Show resolved Hide resolved
@Xuanwo Xuanwo changed the title feat(services/azblob)!: Rewrite the method signatures using OpWrite feat(services/azblob): Rewrite the method signatures using OpWrite Sep 14, 2023
@Xuanwo Xuanwo mentioned this pull request Sep 14, 2023
Closed
13 tasks
Xuanwo
Xuanwo approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! By the way, I noticed that azblob_get_blob from azblob could also be refactored by OpRead. Maybe you would be interested in sending a pull request as well?

@acehinnnqru
Copy link
Contributor Author

Thank you very much! By the way, I noticed that azblob_get_blob from azblob could also be refactored by OpRead. Maybe you would be interested in sending a pull request as well?

Wow, that's my miss. should I continue to push to this PR?

@Xuanwo
Copy link
Member

Xuanwo commented Sep 14, 2023

should I continue to push to this PR?

You can start a new PR ❤️

@Xuanwo Xuanwo merged commit 6187b6d into apache:main Sep 14, 2023
30 checks passed
@acehinnnqru acehinnnqru deleted the feat/rewrite-azblob-methods branch September 14, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acehinnnqru @Xuanwo