Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(services/oss): Refactor oss_put_object signatures by using OpWrite #3080

Merged
merged 2 commits into from
Sep 15, 2023
Merged

refactor(services/oss): Refactor oss_put_object signatures by using OpWrite #3080

merged 2 commits into from
Sep 15, 2023

Conversation

sysu-yunz
Copy link
Contributor

@sysu-yunz sysu-yunz commented Sep 15, 2023 •
edited
Loading

#3064

  • Refactor oss_put_object oss_put_object_request function in services/oss core.rs
  • Usage of oss_put_object_request in writer.rs and backend.rs also changed

@sysu-yunz sysu-yunz changed the title refactor(services/oss): Refactor oss_put_object signatures by using OpWrite Refactor(services/oss): Refactor oss_put_object signatures by using OpWrite Sep 15, 2023
@Xuanwo Xuanwo mentioned this pull request Sep 15, 2023
Closed
13 tasks
@Xuanwo Xuanwo changed the title Refactor(services/oss): Refactor oss_put_object signatures by using OpWrite refactor(services/oss): Refactor oss_put_object signatures by using OpWrite Sep 15, 2023
Xuanwo
Xuanwo approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit d797f05 into apache:main Sep 15, 2023
32 checks passed
@sysu-yunz sysu-yunz deleted the dev/refactor-op-in-oss branch September 15, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sysu-yunz @Xuanwo