chore(core): use stabilized LazyLock instead of once_cell::sync::Lazy
#5252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koushiro
changed the title
LazyLock instead of once_cell::sync::LazyLazyLock instead of once_cell::sync::Lazy
koushiro
force-pushed
the
replace-once-cell
branch
from
c1cc419
to
1c1faab
Compare
**BREAKING CHANGE**: MSRV: 1.75 => 1.80
koushiro
force-pushed
the
replace-once-cell
branch
from
1c1faab
to
78d107b
Compare
Hi, we might still have users who need MSRV 1.75. It's better to start a discussion before submitting this PR. |
Alright, let's put this PR aside for now. |
|
It's unlikely that we will update the MSRV to 1.80 soon. Would you like to convert this into an issue and submit a PR for it in the future when we are ready to increase the MSRV to 1.80? |
|
I think we can close this PR for now and reopen it when MSRV is upgraded to 1.80 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No
Rationale for this change
What changes are included in this PR?
std::sync::LazyLockinstead ofonce_cell::sync::Lazyonce_celldependency fromopendalcoreAre there any user-facing changes?
MSRV: 1.75 => 1.80