Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): upgrade msrv of opendal core to 1.80 #5254

Closed
wants to merge 2 commits into from

Conversation

koushiro
Copy link
Contributor

Which issue does this PR close?

Close #5253

Rationale for this change

This is a pre-modification of #5252. I want to keep the modification of #5252 as pure as possible.

What changes are included in this PR?

  • upgrade MSRV of opendal core: 1.75 => 1.80
  • use inspect and inspect_err instead of map and map_err to fix clippy warnings

Are there any user-facing changes?

MSRV: 1.75 => 1.80

@Xuanwo
Copy link
Member

Xuanwo commented Oct 31, 2024

As discussed in #5253 and #5256, it's unlikely this will be updated to 1.80 soon. Would you like to close this PR and wait?

@koushiro
Copy link
Contributor Author

Yeah, we can reopen this PR when we need it

@koushiro koushiro closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants