adapt tests for provide-api-key annotation upstream #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matthiaskubik
commented
Apr 10, 2019
matthiaskubik
commented
- bumped gradle version due to SSL errors
- copied changes from Improve Robustness of WskRestBasicUsageTests openwhisk#4423
rabbah
reviewed
Apr 10, 2019
|
This PR should be merged without squashing independent commits in case we need to roll back. Ideally orthogonal changes are in different PRs. Edit: the first commit already conflates the gradle bump and the test updates. @matthiaskubik could you please re-stage the patches to separate the two changes into individual commits. |
|
@matthiaskubik I'm going to bump the gradle version to 4.10.2 in this PR #395. This PR then will address just the test changes. Sorry for the confusion. I'm trying to reduce the work for you. |
rabbah
changed the title
|
@matthiaskubik i rebased your PR to master to pick up the gradle bump and retitled your PR accordingly. Thanks for the contribution and fixing the tests. |
rabbah
approved these changes
Apr 11, 2019
|
Thanks @matthiaskubik for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.