remove namespace property from wskprops #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry @rabbah, for the late response. I tested the changes and all looks good. |
|
I built the cli and I tried with an existing configuration with a namespace: Old: New: |
|
Thanks @neerajmangal @sciabarracom. |
This was referenced Nov 28, 2019
|
@rabbah I think this doc needs update then It still shows the --namespace flag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setting of a namespace in wskprops can lead to surprising failures when it does not match the auth key. This value used to be there when namespaces and keys were not 1-1 but that hasn't been the case for a long time.
This patch remove --namespace from property set/unset but preserves --namespace in property get.
Partially fixes #137. Will open a subsequent PR to re-purpose
wsk namespace get.