Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][broker] Support clear old bookie data for BKCluster #16744

Merged
merged 3 commits into from
Jul 25, 2022

Conversation

coderzc
Copy link
Member

@coderzc coderzc commented Jul 22, 2022

Fixes #16741

Motivation

Currently, BKCluster does not support clear old bookie data leading to the --wipe-data feature not working when start bookie with rocksdb.

Modifications

Support clear old bookie data for BKCluster.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as EndToEndMetadataTest.

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@codelipenghui codelipenghui added release/2.10.2 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/broker labels Jul 23, 2022
@codelipenghui codelipenghui added this to the 2.11.0 milestone Jul 23, 2022
@github-actions
Copy link

@coderzc Please provide a correct documentation label for your PR.
Instructions see Pulsar Documentation Label Guide.

@coderzc
Copy link
Member Author

coderzc commented Jul 24, 2022

/pulsarbot rerun-failure-checks

1 similar comment
@coderzc
Copy link
Member Author

coderzc commented Jul 24, 2022

/pulsarbot rerun-failure-checks

@codelipenghui codelipenghui merged commit eb5725a into apache:master Jul 25, 2022
@Jason918
Copy link
Contributor

Jason918 commented Sep 1, 2022

@coderzc Can you open a new PR to merge this to branch-2.10 ? There are a lot of conflicts when cherry-pick.

liangyepianzhou pushed a commit that referenced this pull request Feb 10, 2023
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker cherry-picked/branch-2.10 doc-label-missing release/2.10.4 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pulsar Standalone: --wipe-data does not work with RocksDB backend
6 participants