-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve][broker] Support clear old bookie data for BKCluster #16744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
force-pushed
the
wipe_rockdb_data
branch
from
July 22, 2022 12:08
e7ff08c
to
6c805a2
Compare
coderzc
force-pushed
the
wipe_rockdb_data
branch
from
July 22, 2022 12:18
6c805a2
to
d5a7268
Compare
codelipenghui
approved these changes
Jul 23, 2022
codelipenghui
added
release/2.10.2
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
area/broker
labels
Jul 23, 2022
@coderzc Please provide a correct documentation label for your PR. |
shibd
approved these changes
Jul 23, 2022
/pulsarbot rerun-failure-checks |
1 similar comment
/pulsarbot rerun-failure-checks |
Technoboy-
reviewed
Jul 25, 2022
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/bookkeeper/BKCluster.java
Outdated
Show resolved
Hide resolved
Technoboy-
approved these changes
Jul 25, 2022
@coderzc Can you open a new PR to merge this to branch-2.10 ? There are a lot of conflicts when cherry-pick. |
liangyepianzhou
pushed a commit
that referenced
this pull request
Feb 10, 2023
(cherry picked from commit eb5725a)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 28, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
cherry-picked/branch-2.10
doc-label-missing
release/2.10.4
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16741
Motivation
Currently, BKCluster does not support clear old bookie data leading to the
--wipe-data
feature not working when start bookie with rocksdb.Modifications
Support clear old bookie data for BKCluster.
Verifying this change
This change is already covered by existing tests, such as EndToEndMetadataTest.
(example:)
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)