Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][cli] Fix Pulsar standalone "--wipe-data" #22885

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jun 9, 2024

Fixes #22881

Motivation

See #22881. The issue wasn't fully addressed in the previous fix for #16741 in #16744. That fix only deletes Bookie data, but not the RocksDB based metadata store.

Modifications

  • Handle deleting the RocksDB metadata store
  • Add logging to all locations when data is wiped

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 3.4.0 milestone Jun 9, 2024
@lhotari lhotari requested review from eolivelli and coderzc June 9, 2024 09:08
@lhotari lhotari self-assigned this Jun 9, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 9, 2024
@lhotari lhotari requested a review from Technoboy- June 10, 2024 10:18
@merlimat merlimat merged commit f6eceed into apache:master Jun 10, 2024
54 of 55 checks passed
lhotari added a commit that referenced this pull request Jun 10, 2024
lhotari added a commit that referenced this pull request Jun 10, 2024
lhotari added a commit that referenced this pull request Jun 10, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 17, 2024
(cherry picked from commit f6eceed)
(cherry picked from commit d9928ef)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 25, 2024
(cherry picked from commit f6eceed)
(cherry picked from commit d9928ef)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 1, 2024
(cherry picked from commit f6eceed)
(cherry picked from commit d9928ef)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pulsar Standalone: --wipe-data does not work with RocksDB backend in 3.2.3
2 participants