[fix][CI] Don't run "Pulsar CI checks completed" too early and fix disk space issue in saving docker image

[lhotari]

Fixes #17583

Motivation

Pulsar CI is broken since "Pulsar CI checks completed" runs too early.
There's another problem that disk space runs out in "Build Pulsar docker image" with error message

Error response from daemon: write /var/lib/docker/tmp/docker-export-3539721826/b4b6ffd2e938fa5512aa646b2c22044e3e0b14e74d3dc8374a9b3723a7235c53/layer.tar: no space left on device

Modifications

• remove "if: always()" since it caused the job to run also when something failed
• release disk space in "Build Pulsar docker image" build job before exporting the docker image

Documentation

• doc-required
  (Your PR needs to update docs and you will update later)

• doc-not-needed
  (Please explain why)

• doc
  (Your PR contains doc changes)

• doc-complete
  (Docs have been already added)

[tisonkun]

I ever wrote another script for running always but check the result of needs to determinate which cleanups can be trigger.

See also https://github.com/apache/incubator-kvrocks/blob/2402dfec05c582235dfb195bb1d4210584e59848/.github/workflows/kvrocks.yaml#L220-L233.

[lhotari]

thanks, nice example. I didn't know about that ${{ needs.build-and-test.result }} trick.

[michaeljmarshall]

LGTM

[nicoloboschi]

Thanks @lhotari
I noticed this issue during the weekend too

[lhotari]

Available disk space before building docker image:

/dev/root         85161M 41518M    43627M  49% /

Available disk space after building docker image:

/dev/root         85161M 83949M     1197M  99% /

I wonder when the build started consuming so much disk space? @tisonkun could it be related to the Trino changes?

[tisonkun]

@lhotari I don't find the possibility by #17062. It does some rename and location change works, while no docker image layer change. You may go through the assembly and dockerfile changes for double check.

[nicoloboschi]

@lhotari something is still wrong.
Unit test Broker 2 timed out: https://github.com/apache/pulsar/runs/8299450001?check_suite_focus=true
Checks completed job has been skipped: https://github.com/apache/pulsar/runs/8300402413?check_suite_focus=true

But I'm still able to merge your pull

[tisonkun]

Hi @lhotari @nicoloboschi according to docker image changes, this patch may be relevant #17129.

[lhotari]

@lhotari something is still wrong. Unit test Broker 2 timed out: https://github.com/apache/pulsar/runs/8299450001?check_suite_focus=true Checks completed job has been skipped: https://github.com/apache/pulsar/runs/8300402413?check_suite_focus=true

But I'm still able to merge your pull

there's a follow up in #17586 to address this problem. This solution is inspired by @tisonkun 's solution in kvrocks (#17584 (comment)).