Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][CI] Don't run "Pulsar CI checks completed" too early and fix disk space issue in saving docker image #17584

Merged
merged 4 commits into from
Sep 12, 2022
Merged

[fix][CI] Don't run "Pulsar CI checks completed" too early and fix disk space issue in saving docker image #17584

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fdb5488
[fix][CI] Don't run "Pulsar CI checks completed" too early
lhotari Sep 12, 2022
13bf4af
Clean up disk space in "Build Pulsar docker image"
lhotari Sep 12, 2022
add4e21
Show disk space before and after cleaning
lhotari Sep 12, 2022
28aa9ff
Fix deleting files
lhotari Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/pulsar-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,7 +844,6 @@ jobs:
'system-tests',
'macos-build'
]
if: always()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ever wrote another script for running always but check the result of needs to determinate which cleanups can be trigger.

See also https://github.com/apache/incubator-kvrocks/blob/2402dfec05c582235dfb195bb1d4210584e59848/.github/workflows/kvrocks.yaml#L220-L233.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, nice example. I didn't know about that ${{ needs.build-and-test.result }} trick.

steps:
- name: checkout
if: ${{ needs.changed_files_job.outputs.docs_only != 'true' }}
Expand Down