[fix][broker] Added the skipped message handler for ServiceUnitStateChannel #20677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nit state channel
2 tasks
Demogorgon314
approved these changes
Jun 29, 2023
Technoboy-
approved these changes
Jun 29, 2023
The cleaner approach would be to expose |
Technoboy-
pushed a commit
that referenced
this pull request
Jul 3, 2023
…hannel (#20677) ### Motivation When topic lookups race(and the first lookup returns too fast before the second request gets deduped), the later lookup requests can timeout because the skipped messages are ignored at the table view and do not notify the service unit state channel. ex: m1: assign to b1 -> m2: owned by b1 -> m3: assign to b2 // m3 is skipped at the tableview When m3 is skipped, we better get the channel notified to return the lookup request with the current owner(b1) instead of letting the request time out. ### Modifications - Added the `handleSkippedMessage` and `setSkippedMsgHandler` in `TopicCompactionStrategy`. - `ServiceUnitStateChannel` registers `ServiceUnitStateChannel.handleSkippedEvent` to `ServiceUnitStateCompactionStrategy` by `setSkippedMsgHandler`. - TableView calls `TopicCompactionStrategy.handleSkippedMessage` when messages are skipped.
| } | ||
|
|
||
|
|
||
| static TopicCompactionStrategy load(String tag, String topicCompactionStrategyClassName) { |
There was a problem hiding this comment.
We should not cherry-pick this public API change to branch-3.0 @Technoboy-
There was a problem hiding this comment.
This API should only use for extensible load managers. I added an annotation to mark this as private, #20858 , please help take a look at this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When topic lookups race(and the first lookup returns too fast before the second request gets deduped), the later lookup requests can timeout because the skipped messages are ignored at the table view and do not notify the service unit state channel.
ex:
m1: assign to b1 -> m2: owned by b1 -> m3: assign to b2 // m3 is skipped at the tableview
When m3 is skipped, we better get the channel notified to return the lookup request with the current owner(b1) instead of letting the request time out.
Modifications
handleSkippedMessageandsetSkippedMsgHandlerinTopicCompactionStrategy.ServiceUnitStateChannelregistersServiceUnitStateChannel.handleSkippedEventtoServiceUnitStateCompactionStrategybysetSkippedMsgHandler.TopicCompactionStrategy.handleSkippedMessagewhen messages are skipped.Verifying this change
This change is already covered by existing tests, such as ServiceUnitStateChannelImpl.conflictAndCompactionTest
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: heesung-sn#48