[improve][broker] Add annotation for topic compaction strategy #20858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
doc-not-needed
|
@heesung-sn Can you help review this PR? |
Technoboy-
approved these changes
Jul 24, 2023
RobertIndie
approved these changes
Jul 24, 2023
14 tasks
|
One concern is that if we want to cherry-pick this PR to branch-3.0 and some users use this API for their ecosystem, this may break the upgrade from 3.0.0 to 3.0.1. After discussing with @Demogorgon314, this interface is only used inside the Pulsar Java client and Pulsar broker. The user is not able to use it. This also doesn't affect the upgrade of the pulsar from 3.0.0 to 3.0.1 |
RobertIndie
added
the
release/blocker
|
Can you share any reference about these annotations? |
heesung-sn
approved these changes
Jul 24, 2023
RobertIndie
pushed a commit
that referenced
this pull request
Jul 26, 2023
### Motivation Add `Audience.Private` annotation for topic compaction strategy. Since this interface only uses for load manager, other users should not use this interface. (cherry picked from commit e55ed58)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add
Audience.Privateannotation for topic compaction strategy. Since this interface only uses for load manager, other users should not use this interface.Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-complete