-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Fix heartbeat namespace create transaction internal topic #21348
Merged
Technoboy-
merged 1 commit into
apache:master
from
TakaHiR07:fix_heartbeat_namespace_create_transaction_internal_topic
Oct 19, 2023
Merged
[fix][broker] Fix heartbeat namespace create transaction internal topic #21348
Technoboy-
merged 1 commit into
apache:master
from
TakaHiR07:fix_heartbeat_namespace_create_transaction_internal_topic
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
requested review from
codelipenghui and
Technoboy-
and removed request for
codelipenghui
October 18, 2023 13:07
Technoboy-
approved these changes
Oct 18, 2023
Technoboy-
requested review from
poorbarcode,
liangyepianzhou and
mattisonchao
October 18, 2023 13:07
codelipenghui
approved these changes
Oct 18, 2023
poorbarcode
approved these changes
Oct 18, 2023
mattisonchao
approved these changes
Oct 18, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Oct 19, 2023
shibd
pushed a commit
to shibd/pulsar
that referenced
this pull request
Oct 22, 2023
…ic (apache#21348) (cherry picked from commit c8a2f49)
shibd
pushed a commit
to shibd/pulsar
that referenced
this pull request
Oct 23, 2023
…ic (apache#21348) (cherry picked from commit c8a2f49)
shibd
pushed a commit
to shibd/pulsar
that referenced
this pull request
Oct 23, 2023
…ic (apache#21348) (cherry picked from commit c8a2f49)
shibd
pushed a commit
to shibd/pulsar
that referenced
this pull request
Oct 24, 2023
…ic (apache#21348) (cherry picked from commit c8a2f49)
14 tasks
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-2.11
cherry-picked/branch-3.0
cherry-picked/branch-3.1
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/2.11.3
release/3.0.2
release/3.1.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If we set transactionCoordinatorEnabled=true, heartbeat namespace create __transaction_buffer_snapshot topic.
Actually heartbeat namespace should not create transaction internal topic.
Modifications
do not construct TransactionBuffer if topic belongs to heartbeat namespace
Verifying this change
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: TakaHiR07#15