-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Don't merge][cherry-pick][branch-2.11] Cherry-pick some PR to branch-2.11 #21427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o after bkclient initialize (apache#20944) (cherry picked from commit d9ebaf5)
…ed on topic, when dedup is enabled and no producer is there (apache#20951) (cherry picked from commit 30073db)
…currently (apache#20971) **Background**: when calling `pulsar-admin topics stats --get-earliest-time-in-backlog <topic name>`, Pulsar will read the first entry which is not acknowledged, and respond with the entry write time. The flow is like this: - get the mark deleted position of the subscription - if no backlog, response `-1` - else read the next position of the mark deleted position, and respond with the entry write time. **Issue**: if the command `pulsar-admin topics stats --get-earliest-time-in-backlog <topic name>` and `consumer.acknowledge` are executed at the same time, the step 2 in above flow will get a position which is larger than the last confirmed position, lead a read entry error. | time | `pulsar-admin topics stats --get-earliest-time-in-backlog <topic name>` | `consumer.acknowledge` | | --- | --- | --- | | 1 | mark deleted position is `3:1` and LAC is `3:2` now | | 2 | the check `whether has backlog` is passed | | 3 | | acknowledged `3:2`, mark deleted position is `3:2` now | | 4 | calculate next position: `3:3` | | 5 | Read `3:3` and get an error: `read entry failed` | Note: the test in PR is not intended to reproduce the issue. Respond `-1` if the next position of the mark deleted position is larger than the LAC (cherry picked from commit 7c96a36)
…tion check. (apache#20983) (cherry picked from commit 43cd86d)
…MinNumRacksPerWriteQuorum not work problem. (apache#21327) (cherry picked from commit 61a7adf)
…ic (apache#21348) (cherry picked from commit c8a2f49)
…elete heartbeat topic (apache#21360) Co-authored-by: fanjianye <[email protected]> Co-authored-by: Jiwei Guo <[email protected]> (cherry picked from commit 700a29d)
… in ModularLoadManagerImpl (apache#19656) (cherry picked from commit 145e985)
shibd
requested review from
Technoboy-,
codelipenghui,
poorbarcode and
mattisonchao
October 24, 2023 02:37
Please do not squash merge this PR, thanks! it will ruin the history of commits. It's better to cherry-pick them one-by-one |
shibd
changed the title
[cherry-pick][branch-2.11] Cherry-pick some PR to branch-2.11
[Don't merge][cherry-pick][branch-2.11] Cherry-pick some PR to branch-2.11
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Release v2.11.3
Modifications
Pick some conflict-free PRs to branch-2.11:
Verifying this change
Does this pull request potentially affect one of the following parts:
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository