Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add judgment for SendLatencyFault in MQFaultStrategy#selectOneMessageQueue #6272

Closed
mxsm opened this issue Mar 7, 2023 · 0 comments · Fixed by #6273
Closed

Add judgment for SendLatencyFault in MQFaultStrategy#selectOneMessageQueue #6272

mxsm opened this issue Mar 7, 2023 · 0 comments · Fixed by #6273

Comments

@mxsm
Copy link
Member

mxsm commented Mar 7, 2023

The issue tracker is used for bug reporting purposes ONLY whereas feature request needs to follow the RIP process. To avoid unnecessary duplication, please check whether there is a previous issue before filing a new one.

It is recommended to start a discussion thread in the mailing lists or github discussions in cases of discussing your deployment plan, API clarification, and other non-bug-reporting issues.
We welcome any friendly suggestions, bug fixes, collaboration, and other improvements.

Please ensure that your bug report is clear and self-contained. Otherwise, it would take additional rounds of communication, thus more time, to understand the problem itself.

Generally, fixing an issue goes through the following steps:

  1. Understand the issue reported;
  2. Reproduce the unexpected behavior locally;
  3. Perform root cause analysis to identify the underlying problem;
  4. Create test cases to cover the identified problem;
  5. Work out a solution to rectify the behavior and make the newly created test cases pass;
  6. Make a pull request and go through peer review;

As a result, it would be very helpful yet challenging if you could provide an isolated project reproducing your reported issue. Anyway, please ensure your issue report is informative enough for the community to pick up. At a minimum, include the following hints:

BUG REPORT

  1. Please describe the issue you observed:
  • What did you do (The steps to reproduce)?

  • What is expected to see?

  • What did you see instead?

  1. Please tell us about your environment:

  2. Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc):

FEATURE REQUEST

image
Before checking the availability of the broker in the latencyFaultTolerance method, we can add a check to see if the lastBrokerName is equal to the selected MessageQueue's broker name.

mxsm added a commit to mxsm/rocketmq that referenced this issue Mar 7, 2023
drpmma pushed a commit that referenced this issue Mar 13, 2023
…ectOneMessageQueue (#6273)

* [ISSUE #6272]Add judgment for SendLatencyFault in MQFaultStrategy#selectOneMessageQueue

* fix code style
fuyou001 pushed a commit to fuyou001/rocketmq that referenced this issue Mar 16, 2023
…gy#selectOneMessageQueue (apache#6273)

* [ISSUE apache#6272]Add judgment for SendLatencyFault in MQFaultStrategy#selectOneMessageQueue

* fix code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants