Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6272]Add judgment for SendLatencyFault in MQFaultStrategy#selectOneMessageQueue #6273

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

mxsm
Copy link
Member

@mxsm mxsm commented Mar 7, 2023

Make sure set the target branch to develop

What is the purpose of the change

fix #6272

Brief changelog

  • Add judgment for SendLatencyFault in MQFaultStrategy#selectOneMessageQueue

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drpmma drpmma merged commit 47355d1 into apache:develop Mar 13, 2023
@mxsm mxsm deleted the rocketmq-6272 branch March 13, 2023 06:27
fuyou001 pushed a commit to fuyou001/rocketmq that referenced this pull request Mar 16, 2023
…gy#selectOneMessageQueue (apache#6273)

* [ISSUE apache#6272]Add judgment for SendLatencyFault in MQFaultStrategy#selectOneMessageQueue

* fix code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add judgment for SendLatencyFault in MQFaultStrategy#selectOneMessageQueue
6 participants