Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The getTopicConfigs method in interface MessageStore maybe not necessary. #6545

Closed
ni-ze opened this issue Apr 6, 2023 · 2 comments · Fixed by #6531
Closed

The getTopicConfigs method in interface MessageStore maybe not necessary. #6545

ni-ze opened this issue Apr 6, 2023 · 2 comments · Fixed by #6531
Assignees

Comments

@ni-ze
Copy link
Contributor

ni-ze commented Apr 6, 2023

The issue tracker is used for bug reporting purposes ONLY whereas feature request needs to follow the RIP process. To avoid unnecessary duplication, please check whether there is a previous issue before filing a new one.

It is recommended to start a discussion thread in the mailing lists or github discussions in cases of discussing your deployment plan, API clarification, and other non-bug-reporting issues.
We welcome any friendly suggestions, bug fixes, collaboration, and other improvements.

Please ensure that your bug report is clear and self-contained. Otherwise, it would take additional rounds of communication, thus more time, to understand the problem itself.

Generally, fixing an issue goes through the following steps:

  1. Understand the issue reported;
  2. Reproduce the unexpected behavior locally;
  3. Perform root cause analysis to identify the underlying problem;
  4. Create test cases to cover the identified problem;
  5. Work out a solution to rectify the behavior and make the newly created test cases pass;
  6. Make a pull request and go through peer review;

As a result, it would be very helpful yet challenging if you could provide an isolated project reproducing your reported issue. Anyway, please ensure your issue report is informative enough for the community to pick up. At a minimum, include the following hints:

BUG REPORT

Map<String, TopicConfig> getTopicConfigs();
Optional<TopicConfig> getTopicConfig(String topic);

Those two methods are not belong to messageStore level, and they are set from BrokerController, and invoked from the store layer, like ConsumeQueueStore and CompactionStore. It can be removed.

  1. Please describe the issue you observed:
  • What did you do (The steps to reproduce)?

  • What is expected to see?

  • What did you see instead?

  1. Please tell us about your environment:
    develop

  2. Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc):

FEATURE REQUEST

  1. Please describe the feature you are requesting.

  2. Provide any additional detail on your proposed use case for this feature.

  3. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?

  4. If there are some sub-tasks involved, use -[] for each sub-task and create a corresponding issue to map to the sub-task:

@ni-ze ni-ze changed the title The getTopicConfigs method in interface MessageStore maybe not so much necessary. The getTopicConfigs method in interface MessageStore maybe not necessary. Apr 7, 2023
@joeCarf
Copy link
Contributor

joeCarf commented Apr 7, 2023

I‘d like to do this

@ni-ze
Copy link
Contributor Author

ni-ze commented Apr 7, 2023

I‘d like to do this

ok.

ni-ze pushed a commit that referenced this issue Apr 15, 2023
…#6531)

* change map -> lambda

* f

* fix unit test

* remove getTopicConfig function

* Update MultiDispatchTest.java

* Update CompactionStore.java

* update

* update test

* update test

* Update BatchConsumeMessageTest.java

* Update BrokerController.java

* Update BrokerController.java

* check

* Update BrokerController.java

* Update BatchConsumeMessageTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants