-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #6545] Remove getTopicConfigs method in interface MessageStore #6531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @joeCarf CI not pass, Please check your code style thanks.
@guyinyou please review this pr. |
@RongtongJin help click and run ci. |
Codecov Report
@@ Coverage Diff @@
## develop #6531 +/- ##
=============================================
- Coverage 43.08% 43.07% -0.01%
+ Complexity 8993 8982 -11
=============================================
Files 1107 1107
Lines 78257 78252 -5
Branches 10201 10201
=============================================
- Hits 33714 33706 -8
+ Misses 40319 40317 -2
- Partials 4224 4229 +5
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Make sure set the target branch to
develop
What is the purpose of the change
fix #6545
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.