Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6545] Remove getTopicConfigs method in interface MessageStore #6531

Merged
merged 19 commits into from
Apr 15, 2023
Merged

[ISSUE #6545] Remove getTopicConfigs method in interface MessageStore #6531

merged 19 commits into from
Apr 15, 2023

Conversation

joeCarf
Copy link
Contributor

@joeCarf joeCarf commented Apr 3, 2023

Make sure set the target branch to develop

What is the purpose of the change

fix #6545

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @joeCarf CI not pass, Please check your code style thanks.

@joeCarf joeCarf changed the title [ISSUE #6521] Use lambda function to prevent modification to topicConfigTable [ISSUE #6545] Remove getTopicConfigs method in interface MessageStore Apr 11, 2023
@ni-ze
Copy link
Contributor

ni-ze commented Apr 13, 2023

@guyinyou please review this pr.

@guyinyou
Copy link
Contributor

@RongtongJin help click and run ci.

@codecov-commenter
Copy link

Codecov Report

Merging #6531 (99132d0) into develop (938b5bb) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #6531      +/-   ##
=============================================
- Coverage      43.08%   43.07%   -0.01%     
+ Complexity      8993     8982      -11     
=============================================
  Files           1107     1107              
  Lines          78257    78252       -5     
  Branches       10201    10201              
=============================================
- Hits           33714    33706       -8     
+ Misses         40319    40317       -2     
- Partials        4224     4229       +5     
Impacted Files Coverage Δ
...n/java/org/apache/rocketmq/store/MessageStore.java 0.00% <ø> (ø)
...ketmq/store/plugin/AbstractPluginMessageStore.java 0.00% <ø> (ø)
...a/org/apache/rocketmq/broker/BrokerController.java 43.53% <100.00%> (-0.06%) ⬇️
...org/apache/rocketmq/store/DefaultMessageStore.java 46.75% <100.00%> (+0.03%) ⬆️
.../org/apache/rocketmq/store/kv/CompactionStore.java 31.73% <100.00%> (ø)
...apache/rocketmq/store/queue/ConsumeQueueStore.java 47.05% <100.00%> (-1.15%) ⬇️

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ni-ze ni-ze merged commit 3fe81bf into apache:develop Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The getTopicConfigs method in interface MessageStore maybe not necessary.
5 participants