Skip to content
This repository has been archived by the owner on Jun 1, 2022. It is now read-only.

feat: remove node-sass, use dart-sass #369

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

xiaoxiangmoe
Copy link
Contributor

@xiaoxiangmoe xiaoxiangmoe commented Oct 27, 2020

https://sass-lang.com/dart-sass

Dart Sass is the primary implementation of Sass, which means it gets new features before any other implementation. It's fast, easy to install, and it compiles to pure JavaScript which makes it easy to integrate into modern web development workflows. Find out more or help out with its development on GitHub.

https://github.com/webpack-contrib/sass-loader/releases/tag/v9.0.0

prefer sass (dart-sass) by default, it is strongly recommended to migrate on sass (dart-sass)

@kezhenxu94 kezhenxu94 added the dependencies Pull requests that update a dependency file label Nov 2, 2020
@kezhenxu94
Copy link
Member

kezhenxu94 commented Nov 2, 2020

@Jtrust can you please take a look?

@Jtrust
Copy link
Member

Jtrust commented Nov 2, 2020

@Jtrust can you please take a look?

It works fine on my PC. And I searched for some relevant information.
The performance evaluation
dart-sass in vue-cli
the future of sass
The underlying dependency of Node-Sass on libsass makes installation difficult for some users, especially Windows users. dart-sass is a good way to avoid this problem.
The compatibility width /deep/ to ::v-deep is not involved in this project.
I think that we could change node-sass to dart-sass.

@kezhenxu94
Copy link
Member

Thanks @Jtrust for confirming

@kezhenxu94 kezhenxu94 merged commit 549819a into apache:master Nov 5, 2020
@kezhenxu94 kezhenxu94 added this to the 8.3.0 milestone Nov 5, 2020
@kezhenxu94 kezhenxu94 mentioned this pull request Nov 9, 2020
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants