Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync ui: label fix in topology chart + dart-sass replacing node-sass #5815

Merged
merged 2 commits into from
Nov 10, 2020

Conversation

zeaposs
Copy link
Contributor

@zeaposs zeaposs commented Nov 9, 2020

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

UI submodule update. List of changes:

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #5815 (dd06447) into master (5b84c5a) will increase coverage by 1.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5815      +/-   ##
============================================
+ Coverage     51.29%   52.57%   +1.28%     
- Complexity     3461     3462       +1     
============================================
  Files          1653      897     -756     
  Lines         35374    22469   -12905     
  Branches       3851     2149    -1702     
============================================
- Hits          18146    11814    -6332     
+ Misses        16329     9700    -6629     
- Partials        899      955      +56     
Impacted Files Coverage Δ Complexity Δ
...g/oap/server/core/cluster/ClusterHealthStatus.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...p/server/core/analysis/metrics/MinLongMetrics.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...er/exporter/provider/grpc/GRPCExporterSetting.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...king/oap/server/configuration/api/ConfigTable.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...skywalking/oap/server/receiver/envoy/als/Role.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...r/receiver/envoy/als/k8s/ServiceNameFormatter.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...alking/oap/server/core/cluster/OAPNodeChecker.java 0.00% <0.00%> (-93.75%) 0.00% <0.00%> (ø%)
...t/status/HierarchyMatchExceptionCheckStrategy.java 9.09% <0.00%> (-90.91%) 1.00% <0.00%> (ø%)
.../analysis/transform/Zipkin2SkyWalkingTransfer.java 0.00% <0.00%> (-90.91%) 0.00% <0.00%> (ø%)
...ywalking/oap/server/library/util/ConnectUtils.java 0.00% <0.00%> (-90.00%) 0.00% <0.00%> (ø%)
... and 1144 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b84c5a...dd06447. Read the comment docs.

Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changes.md file in the root of this repo. Thanks.

@wu-sheng wu-sheng added this to the 8.3.0 milestone Nov 9, 2020
@wu-sheng wu-sheng added feature New feature submodule update Change submodule commit ID, including network protocol, query GraphQL and UI UI UI and front end related. labels Nov 9, 2020
@zeaposs
Copy link
Contributor Author

zeaposs commented Nov 9, 2020

Please update the changes.md file in the root of this repo. Thanks.
I'm blind... I've followed the link in template, which leads to 8.2 markdown document and I didn't checked, if file in root is already updated to 8.3.

Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry about the template, I will fix this link soon

@wu-sheng wu-sheng merged commit b8297c1 into apache:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature submodule update Change submodule commit ID, including network protocol, query GraphQL and UI UI UI and front end related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants