Support async profiler feature #12671
Conversation
|
The proto changes seem very concern. As those things are never merged. You should not be able to update those submodules. |
zhengziyi0117
force-pushed
the
async-profiler
branch
from
9c46916
to
2283de3
Compare
zhengziyi0117
force-pushed
the
async-profiler
branch
from
2283de3
to
da4bc45
Compare
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| /* | ||
| * Copyright The async-profiler authors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ |
There was a problem hiding this comment.
I have concerned about these dual headers. Could you confirm whether we changed this file contents? If not, we should keep their license and add exclusions for header checking.
There was a problem hiding this comment.
LGTM! Finally all CI pass!
Great thanks to @wu-sheng, @mrproliu and of course @zhengziyi0117 for your hard work
| @@ -0,0 +1,85 @@ | |||
| `# Async Profiler | |||
There was a problem hiding this comment.
| `# Async Profiler | |
| # Async Profiler |
| Learn more tech details from the post, [**Use Profiling to Fix the Blind Spot of Distributed | ||
| Tracing**](sdk-profiling.md). | ||
|
|
||
| ### Tracing Profiling |
There was a problem hiding this comment.
This part should be kept in Tracing Profiling.
zhengziyi0117
dismissed stale reviews from wu-sheng and lujiajing1126
via
978baa9
Co-authored-by: 吴晟 Wu Sheng <[email protected]>
Co-authored-by: 吴晟 Wu Sheng <[email protected]>
Co-authored-by: 吴晟 Wu Sheng <[email protected]>
Co-authored-by: 吴晟 Wu Sheng <[email protected]>
Co-authored-by: 吴晟 Wu Sheng <[email protected]>
Co-authored-by: 吴晟 Wu Sheng <[email protected]>
Co-authored-by: 吴晟 Wu Sheng <[email protected]>
|
2 comments of mine are still not addressed, you can merge this as you wish but make sure to address later or explain why they can’t be addressed: |
@zhengziyi0117 Please address this in a new pull request. We need to make this 100% ready, because this will be in SkyWalking next major feature release. |
Integrate async profiler performance analysis function in Java
CHANGESlog.