-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support async profiler feature #12671
Merged
Merged
Changes from all commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
da4bc45
feat: support async-profiler feature
3918477
feat: add banyandb and jdbc support
92fb3e6
fix: Make code conform to the protocol & some e2e
71a121e
fix: merge master
af2836d
fix: skywalking-ui git commit
da94432
fix: checkstyle && banyandb support fix
b21c883
fix: license
e80fff0
fix: license
e73cd52
fix: license
f3acffd
feat: e2e test case
8d85986
feat: e2e test case
9217279
fix: protocol modify
bd49c35
fix: e2e test retry
2874282
fix: e2e test
db33bd7
fix: e2e
24f4443
fix: e2e
26dc542
Merge branch 'master' into async-profiler
lujiajing1126 2565743
fix: jfr oversize case
2f2648d
Merge branch 'master' into async-profiler
lujiajing1126 0954543
fix: license
ee68f88
fix: license
db6cb3b
fix: e2e java agent sha
b6d85ba
fix: file format
8d21346
feat: e2e storage
d47031a
feat: e2e storage
209b2da
feat: e2e storage
ef7c2fe
feat: async profiler doc
f5e7a49
fix: ci
e7c3310
Update oap-server/server-core/src/main/java/org/apache/skywalking/oap…
zhengziyi0117 3f9c040
fix: comment
fcd07f4
Merge remote-tracking branch 'origin/async-profiler' into async-profiler
c102b87
fix: ci
8ecf623
fix: ci
13ef772
fix: doc
3fcf650
fix: e2e
689231e
fix: cluster case
981f77b
fix: e2e
881f3be
fix: e2e
2d83ce9
fix: e2e
684e757
Update apm-protocol/apm-network/src/main/java/org/apache/skywalking/o…
zhengziyi0117 8719145
fix: command
cfd3353
fix: license
cc4b8b9
Update configuration-vocabulary.md
zhengziyi0117 ce5a4ca
fix: some e2e
940eabc
fix: some e2e
ed47b94
fix: some e2e
29aaff2
Merge branch 'master' into async-profiler
wu-sheng c6233d0
feat: async profiler document
84b6729
fix: add debuggingtrace for e2e test case
f54bb78
fix: Update the javaagent version to solve the jdk8 file upload problem
935c8c4
fix: add debuggingtrace for e2e test case
f2766c7
fix: add debuggingtrace for e2e test case
5bd428c
fix: add debuggingtrace for e2e test case
99f6f4b
fix: add debuggingtrace for e2e test case
1b6c7bf
fix: add debuggingtrace for e2e test case
b831947
fix meter cases
lujiajing1126 535ff6e
fix: add debuggingtrace for e2e test case
978baa9
fix: add changes.md && backend-async-profiler.md document error
e496257
Update docs/en/setup/backend/backend-async-profiler.md
zhengziyi0117 e87cad6
Update docs/en/setup/backend/backend-async-profiler.md
zhengziyi0117 35b87c3
Update docs/en/setup/backend/backend-async-profiler.md
zhengziyi0117 5ac6676
Update docs/en/setup/backend/backend-async-profiler.md
zhengziyi0117 02ac1d7
Update docs/en/setup/backend/backend-async-profiler.md
zhengziyi0117 22eecd1
Update docs/en/setup/backend/backend-async-profiler.md
zhengziyi0117 8536ddb
Update docs/en/setup/backend/backend-async-profiler.md
zhengziyi0117 a2fecde
fix: changes.md grammar error
b9be4b5
fix: remove useless class AsyncProfilerFileCollectionObserver.java
d3248fd
Merge remote-tracking branch 'origin/async-profiler' into async-profiler
6dbc7d3
fix: profiling.md
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
118 changes: 118 additions & 0 deletions
118
...pache/skywalking/oap/server/network/trace/component/command/AsyncProfilerTaskCommand.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,118 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.apache.skywalking.oap.server.network.trace.component.command; | ||
|
||
import lombok.Getter; | ||
import org.apache.skywalking.apm.network.common.v3.Command; | ||
import org.apache.skywalking.apm.network.common.v3.KeyStringValuePair; | ||
|
||
import java.util.List; | ||
import java.util.Objects; | ||
|
||
@Getter | ||
public class AsyncProfilerTaskCommand extends BaseCommand implements Serializable, Deserializable<AsyncProfilerTaskCommand> { | ||
public static final Deserializable<AsyncProfilerTaskCommand> DESERIALIZER = new AsyncProfilerTaskCommand("", "", 0, null, "", 0); | ||
public static final String NAME = "AsyncProfilerTaskQuery"; | ||
|
||
/** | ||
* async-profiler taskId | ||
*/ | ||
private final String taskId; | ||
/** | ||
* run profiling for duration (second) | ||
*/ | ||
private final int duration; | ||
/** | ||
* async profiler extended parameters. Here is a table of optional parameters. | ||
* | ||
* <p>lock[=DURATION] - profile contended locks overflowing the DURATION ns bucket (default: 10us)</p> | ||
* <p>alloc[=BYTES] - profile allocations with BYTES interval</p> | ||
* <p>interval=N - sampling interval in ns (default: 10'000'000, i.e. 10 ms)</p> | ||
* <p>jstackdepth=N - maximum Java stack depth (default: 2048)</p> | ||
* <p>chunksize=N - approximate size of JFR chunk in bytes (default: 100 MB) </p> | ||
* <p>chunktime=N - duration of JFR chunk in seconds (default: 1 hour) </p> | ||
* details @see <a href="https://github.com/async-profiler/async-profiler/blob/master/src/arguments.cpp#L44">async-profiler argument</a> | ||
*/ | ||
private final String execArgs; | ||
/** | ||
* task create time | ||
*/ | ||
private final long createTime; | ||
|
||
public AsyncProfilerTaskCommand(String serialNumber, String taskId, int duration, | ||
List<String> events, String execArgs, long createTime) { | ||
super(NAME, serialNumber); | ||
this.taskId = taskId; | ||
this.duration = duration; | ||
this.createTime = createTime; | ||
String comma = ","; | ||
StringBuilder sb = new StringBuilder(); | ||
if (Objects.nonNull(events) && !events.isEmpty()) { | ||
sb.append("event=").append(String.join(comma, events)); | ||
} | ||
if (execArgs != null && !execArgs.isEmpty()) { | ||
sb.append(comma).append(execArgs); | ||
} | ||
this.execArgs = sb.toString(); | ||
} | ||
|
||
public AsyncProfilerTaskCommand(String serialNumber, String taskId, int duration, | ||
String execArgs, long createTime) { | ||
super(NAME, serialNumber); | ||
this.taskId = taskId; | ||
this.duration = duration; | ||
this.execArgs = execArgs; | ||
this.createTime = createTime; | ||
} | ||
|
||
@Override | ||
public AsyncProfilerTaskCommand deserialize(Command command) { | ||
final List<KeyStringValuePair> argsList = command.getArgsList(); | ||
String taskId = null; | ||
int duration = 0; | ||
String execArgs = null; | ||
long createTime = 0; | ||
String serialNumber = null; | ||
for (final KeyStringValuePair pair : argsList) { | ||
if ("SerialNumber".equals(pair.getKey())) { | ||
serialNumber = pair.getValue(); | ||
} else if ("TaskId".equals(pair.getKey())) { | ||
taskId = pair.getValue(); | ||
} else if ("Duration".equals(pair.getKey())) { | ||
duration = Integer.parseInt(pair.getValue()); | ||
} else if ("ExecArgs".equals(pair.getKey())) { | ||
execArgs = pair.getValue(); | ||
} else if ("CreateTime".equals(pair.getKey())) { | ||
createTime = Long.parseLong(pair.getValue()); | ||
} | ||
} | ||
return new AsyncProfilerTaskCommand(serialNumber, taskId, duration, execArgs, createTime); | ||
} | ||
|
||
@Override | ||
public Command.Builder serialize() { | ||
final Command.Builder builder = commandBuilder(); | ||
builder.addArgs(KeyStringValuePair.newBuilder().setKey("TaskId").setValue(taskId)) | ||
.addArgs(KeyStringValuePair.newBuilder().setKey("Duration").setValue(String.valueOf(duration))) | ||
.addArgs(KeyStringValuePair.newBuilder().setKey("ExecArgs").setValue(execArgs)) | ||
.addArgs(KeyStringValuePair.newBuilder().setKey("CreateTime").setValue(String.valueOf(createTime))); | ||
return builder; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,85 @@ | ||
# Async Profiler | ||
|
||
Async Profiler is bound within the auto-instrument agent and corresponds to [In-Process Profiling](../../concepts-and-designs/profiling.md#in-process-profiling). | ||
|
||
It is passed to the proxy in the form of a task, allowing it to be enabled or disabled dynamically. | ||
When service encounters performance issues (cpu usage, memory allocation, locks), async-profiler task can be created. | ||
When the proxy receives a task, it enables Async Profiler for sampling. | ||
After sampling is completed, a flame graph will be generated for performance analysis to determine the specific business code line that caused the performance problem. | ||
|
||
## Activate async profiler in the OAP | ||
OAP and the agent use a brand-new protocol to exchange Async Profiler data, so it is necessary to start OAP with the following configuration: | ||
|
||
```yaml | ||
receiver-async-profiler: | ||
selector: ${SW_RECEIVER_ASYNC_PROFILER:default} | ||
default: | ||
``` | ||
|
||
## Async Profiler Task with Analysis | ||
|
||
To use the Async Profiler feature, please follow these steps: | ||
|
||
1. **Create Async Profiler task**: Use the UI or CLI tool to create a task. | ||
2. **Wait agent collect data and upload**: Wait for Async Profiler to collect JFR data and report | ||
3. **Query task progress**: Query the progress of tasks, including analyzing successful and failed instances and task logs | ||
4. **Analyze the data**: Analyze the JFR data to determine where performance bottlenecks exist in the service. | ||
|
||
### Create an Async Profiler task | ||
|
||
Create an Async Profiler task to notify some java-agent instances in the execution service to start Async Profiler for data collection. | ||
|
||
When creating a task, the following configuration fields are required: | ||
|
||
1. **serviceId**: Define the service to execute the task. | ||
2. **serviceInstanceIds**: Define which instances need to execute tasks. | ||
3. **duration**: Define the duration of this task (second). | ||
4. **events**: Define which event types this task needs to collect. | ||
5. **execArgs**: Other Async Profiler execution options, e.g. alloc=2k,lock=2s. | ||
|
||
When the Agent receives a Async Profiler task from OAP, it automatically generates a log to notify that the task has been acknowledged. The log contains the following field information: | ||
|
||
1. **Instance**: The name of the instance where the Agent is located. | ||
2. **Type**: Supports "NOTIFIED" and "EXECUTION_FINISHED" and "JFR_UPLOAD_FILE_TOO_LARGE_ERROR", "EXECUTION_TASK_ERROR", with the current log displaying "NOTIFIED". | ||
3. **Time**: The time when the Agent received the task. | ||
|
||
### Wait the agent to collect data and upload | ||
|
||
At this point, async-profiler will trace the following kinds of events: | ||
|
||
1. CPU cycles | ||
2. Hardware and Software performance counters like cache misses, branch misses, page faults, context switches etc. | ||
3. Allocations in Java Heap | ||
4. Contented lock attempts, including both Java object monitors and ReentrantLocks | ||
|
||
Finally, java agent will upload the jfr file produced by async-profiler to the oap server for online performance analysis. | ||
|
||
### Query the profiling task progresses | ||
|
||
Wait for async-profiler to complete data collection and upload successfully,We can query the execution log of the async-profiler task and the successful and failed instances,which includes the following information: | ||
|
||
1. **successInstanceIds**: SuccessInstanceIds gives instances that have executed the task successfully. | ||
2. **errorInstanceIds**: ErrorInstanceIds gives instances that failed to execute the task. | ||
3. **logs**: All task execution logs of the current task. | ||
1. **id**: The task id. | ||
2. **instanceId**: InstanceId is the id of the instance which reported this task log. | ||
3. **instanceName**: InstanceName is the name of the instance which reported this task log. | ||
4. **operationType**: Contains "NOTIFIED" and "EXECUTION_FINISHED" and "JFR_UPLOAD_FILE_TOO_LARGE_ERROR", "EXECUTION_TASK_ERROR". | ||
5. **operationTime**: operationTime is the time when the operation occurs. | ||
|
||
### Analyze the profiling data | ||
|
||
Once some agents completed the task, we can analyze the data through the following query: | ||
|
||
1. **taskId**: The task id. | ||
2. **instanceIds**: InstanceIds defines the instances to be included for analysis | ||
3. **eventType**: EventType is the specific JFR Event type to be selected for analysis even if multiple events are included in the JFR file. | ||
|
||
After the query, the following data would be returned to render a flame graph: | ||
1. **type**: eventType in query parameters. | ||
2. **elements**: Combined with "id" to determine the hierarchical relationship. | ||
1. **Id**: Id is the identity of the stack element. | ||
2. **parentId**: Parent element ID. The dependency relationship between elements can be determined using the element ID and parent element ID. | ||
3. **codeSignature**: Method signatures in tree nodes. | ||
4. **total**:The total number of samples of the current tree node, including child nodes. | ||
5. **self**: The sampling number of the current tree node, excluding samples of the children. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still only have two kinds of profiling. Could you put async profiler in the current catalog? Is it running in-process or out-process?