Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-15095] [SQL] remove HiveSessionHook from ThriftServer #12881

Closed
wants to merge 1 commit into from
Closed

[SPARK-15095] [SQL] remove HiveSessionHook from ThriftServer #12881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionHook.java
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/SessionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,17 +268,6 @@ public SessionHandle openSession(TProtocolVersion protocol, String username, Str
if (isOperationLogEnabled) {
session.setOperationLogSessionDir(operationLogRootDir);
}
try {
executeSessionHooks(session);
} catch (Exception e) {
try {
session.close();
} catch (Throwable t) {
LOG.warn("Error closing session", t);
}
session = null;
throw new HiveSQLException("Failed to execute session hooks", e);
}
handleToSession.put(session.getSessionHandle(), session);
return session.getSessionHandle();
}
Expand Down Expand Up @@ -361,15 +350,6 @@ public static void clearProxyUserName() {
threadLocalProxyUserName.remove();
}

// execute session hooks
private void executeSessionHooks(HiveSession session) throws Exception {
List<HiveSessionHook> sessionHooks = HookUtils.getHooks(hiveConf,
HiveConf.ConfVars.HIVE_SERVER2_SESSION_HOOK, HiveSessionHook.class);
for (HiveSessionHook sessionHook : sessionHooks) {
sessionHook.run(new HiveSessionHookContextImpl(session));
}
}

public Future<?> submitBackgroundOperation(Runnable r) {
return backgroundOperationPool.submit(r);
}
Expand Down