[SPARK-48191][SQL] Support UTF-32 for string encode and decode #46469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
approved these changes
May 8, 2024
yaooqinn
approved these changes
May 8, 2024
|
Thank you all. Merged to master |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
### What changes were proposed in this pull request? Enable support of UTF-32 ### Why are the changes needed? It already works, so we just need to enable it ### Does this PR introduce _any_ user-facing change? Yes, `decode(..., 'UTF-32')` and `encode(..., 'UTF-32')` will start working ### How was this patch tested? Manually checked in the spark shell ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#46469 from vladimirg-db/vladimirg-db/support-utf-32-for-string-decode. Authored-by: Vladimir Golubev <[email protected]> Signed-off-by: Kent Yao <[email protected]>
MaxGekk
pushed a commit
that referenced
this pull request
Aug 22, 2024
### What changes were proposed in this pull request? The pr aims to update the related docs after `encoding` and `decoding` support `UTF-32`, includes: - the `doc` of the sql config `spark.sql.legacy.javaCharsets` - connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/functions.scala - sql/core/src/main/scala/org/apache/spark/sql/functions.scala - python/pyspark/sql/functions/builtin.py ### Why are the changes needed? After the pr #46469, `UTF-32` for string encoding and decoding is already supported, but some related documents have not been updated synchronously. Let's update it to avoid misunderstandings for end-users and developers. https://github.com/apache/spark/blob/e93c5fbe81d21f8bf2ce52867013d06a63c7956e/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/CharsetProvider.scala#L26 ### Does this PR introduce _any_ user-facing change? Yes, fix doc. ### How was this patch tested? Nope, only fixed some docs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #47844 from panbingkun/SPARK-49353. Authored-by: panbingkun <[email protected]> Signed-off-by: Max Gekk <[email protected]>
IvanK-db
pushed a commit
to IvanK-db/spark
that referenced
this pull request
Sep 20, 2024
### What changes were proposed in this pull request? The pr aims to update the related docs after `encoding` and `decoding` support `UTF-32`, includes: - the `doc` of the sql config `spark.sql.legacy.javaCharsets` - connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/functions.scala - sql/core/src/main/scala/org/apache/spark/sql/functions.scala - python/pyspark/sql/functions/builtin.py ### Why are the changes needed? After the pr apache#46469, `UTF-32` for string encoding and decoding is already supported, but some related documents have not been updated synchronously. Let's update it to avoid misunderstandings for end-users and developers. https://github.com/apache/spark/blob/e93c5fbe81d21f8bf2ce52867013d06a63c7956e/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/CharsetProvider.scala#L26 ### Does this PR introduce _any_ user-facing change? Yes, fix doc. ### How was this patch tested? Nope, only fixed some docs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47844 from panbingkun/SPARK-49353. Authored-by: panbingkun <[email protected]> Signed-off-by: Max Gekk <[email protected]>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? The pr aims to update the related docs after `encoding` and `decoding` support `UTF-32`, includes: - the `doc` of the sql config `spark.sql.legacy.javaCharsets` - connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/functions.scala - sql/core/src/main/scala/org/apache/spark/sql/functions.scala - python/pyspark/sql/functions/builtin.py ### Why are the changes needed? After the pr apache#46469, `UTF-32` for string encoding and decoding is already supported, but some related documents have not been updated synchronously. Let's update it to avoid misunderstandings for end-users and developers. https://github.com/apache/spark/blob/e93c5fbe81d21f8bf2ce52867013d06a63c7956e/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/CharsetProvider.scala#L26 ### Does this PR introduce _any_ user-facing change? Yes, fix doc. ### How was this patch tested? Nope, only fixed some docs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47844 from panbingkun/SPARK-49353. Authored-by: panbingkun <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable support of UTF-32
Why are the changes needed?
It already works, so we just need to enable it
Does this PR introduce any user-facing change?
Yes,
decode(..., 'UTF-32')andencode(..., 'UTF-32')will start workingHow was this patch tested?
Manually checked in the spark shell
Was this patch authored or co-authored using generative AI tooling?
No