Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WW-5339 Enforce exclusion list in CompoundRootAccessor #743

Closed
wants to merge 5 commits into from
Closed

WW-5339 Enforce exclusion list in CompoundRootAccessor #743

wants to merge 5 commits into from

Conversation

kusalk
Copy link
Member

@kusalk kusalk commented Aug 30, 2023

WW-5339

TBA

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

77.1% 77.1% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@kusalk
Copy link
Member Author

kusalk commented Aug 30, 2023 •
edited
Loading

Having done some further testing, I don't believe this mitigation to be necessary. There isn't anything inherently dangerous about just loading the class. Class members are still subject to SecurityMemberAccess checks and static fields can be blocked with the following option.

struts.ognl.allowStaticFieldAccess=false

@kusalk kusalk closed this Aug 30, 2023
@kusalk kusalk mentioned this pull request Sep 26, 2023
Merged
@kusalk kusalk deleted the WW-5339-node-constr branch December 12, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kusalk