Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WW-5339 Misc clean up in CompoundRootAccessor and OgnlValueStackTest #745

Merged
merged 2 commits into from
Sep 26, 2023
Merged

WW-5339 Misc clean up in CompoundRootAccessor and OgnlValueStackTest #745

merged 2 commits into from
Sep 26, 2023

Conversation

kusalk
Copy link
Member

@kusalk kusalk commented Aug 30, 2023

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

41.4% 41.4% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

lukaszlenart
lukaszlenart approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@lukaszlenart lukaszlenart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lukaszlenart
Copy link
Member

Should we merge or close this PR?

@kusalk
Copy link
Member Author

kusalk commented Sep 26, 2023 •
edited
Loading

@lukaszlenart It's good to merge. I closed the original Jira issue and PR (#743) as I realised after more testing that those changes were unnecessary. I instead made this PR with just the clean up changes from that previous PR.

@lukaszlenart lukaszlenart merged commit fde2b70 into master Sep 26, 2023
6 of 7 checks passed
@lukaszlenart lukaszlenart deleted the WW-5339-cleanup branch September 26, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszlenart lukaszlenart lukaszlenart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kusalk @lukaszlenart