refactor: Removes the deprecated DASHBOARD_FILTERS_EXPERIMENTAL feature flag

[michael-s-molina]

SUMMARY

As part of the 4.0 approved initiatives, this PR removes the DASHBOARD_FILTERS_EXPERIMENTAL feature flag and the associated GroupByFilterPlugin.

The previous value of the feature flag was False and now the feature is permanently removed.

TESTING INSTRUCTIONS

CI should be sufficient for merging this PR. We'll do a complete testing of 4.0 after all approved proposals are merged.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4d9144e) 69.26% compared to head (af851fa) 69.30%.
Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #26330      +/-   ##
==========================================
+ Coverage   69.26%   69.30%   +0.03%     
==========================================
  Files        1924     1918       -6     
  Lines       75030    74982      -48     
  Branches     8427     8410      -17     
==========================================
- Hits        51973    51968       -5     
+ Misses      20910    20867      -43     
  Partials     2147     2147              

Flag	Coverage Δ
hive	53.59% <ø> (ø)
javascript	56.84% <ø> (+0.05%)	⬆️
mysql	77.84% <ø> (+0.02%)	⬆️
postgres	77.94% <ø> (ø)
presto	53.54% <ø> (ø)
python	82.79% <ø> (-0.01%)	⬇️
sqlite	77.52% <ø> (ø)
unit	56.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[villebro]

@michael-s-molina was there broad agreement to remove the groupby Filter? The reason I ask is because I don't think it's been marked as deprecated, and I believe some orgs may be using it. Ping @amitmiran137 @simcha90 @cccs-jc @cccs-rc for heads up and any concerns if you missed the discussion (not sure if this is relevant for your orgs or not).

While I'm sure this should rather be brought up in the town hall, I think there's good use cases for the groupby filter, and cleaning it up and adding full support to the ECharts plugin package could be a fairly low hanging fruit, and one that I could potentially take on if this is still deemed relevant for other users.

[michael-s-molina]

@villebro It's a good question. We can submit a specific proposal for lazy consensus for removing the GroupByFilterPlugin and see if someone is using it and is able to support it. If not, then let's remove it.

[michael-s-molina]

The drill by feature provides a similar functionality as the GroupByFilterPlugin and for that reason we may choose to remove the plugin.

[cccs-rc]

@michael-s-molina was there broad agreement to remove the groupby Filter? The reason I ask is because I don't think it's been marked as deprecated, and I believe some orgs may be using it. Ping @amitmiran137 @simcha90 @cccs-jc @cccs-rc for heads up and any concerns if you missed the discussion (not sure if this is relevant for your orgs or not).

While I'm sure this should rather be brought up in the town hall, I think there's good use cases for the groupby filter, and cleaning it up and adding full support to the ECharts plugin package could be a fairly low hanging fruit, and one that I could potentially take on if this is still deemed relevant for other users.

Thanks for the heads up @villebro! We're not currently using the Group By filters, but admittedly that's only because I hadn't spotted the feature flag before. I agree there are good use cases for it that aren't entirely covered by the drill by feature.