Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: run react-codemod sort-comp #12395

Closed
wants to merge 1 commit into from

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Jan 10, 2021

SUMMARY

Sort component methods with react-codemod sort-comp to appease ESLint.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

CI must pass.

ADDITIONAL INFORMATION

@codecov-io
Copy link

codecov-io commented Jan 10, 2021

Codecov Report

Merging #12395 (1b4e4c5) into master (9acf48f) will increase coverage by 1.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12395      +/-   ##
==========================================
+ Coverage   62.83%   64.21%   +1.38%     
==========================================
  Files        1014      485     -529     
  Lines       49489    29888   -19601     
  Branches     5073        0    -5073     
==========================================
- Hits        31095    19194   -11901     
+ Misses      18184    10694    -7490     
+ Partials      210        0     -210     
Flag Coverage Δ
javascript ?
python 64.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-frontend/src/components/TableView/index.ts
...c/visualizations/TimeTable/TimeTableChartPlugin.js
...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx
superset-frontend/src/components/AnchorLink.jsx
...nd/src/dashboard/util/getFilterScopeParentNodes.js
superset-frontend/src/modules/AnnotationTypes.js
...rc/dashboard/util/getLayoutComponentFromChartId.js
...tend/src/filters/components/Select/controlPanel.ts
...hboard/components/gridComponents/new/NewHeader.jsx
...hboard/components/nativeFilters/CascadePopover.tsx
... and 466 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9acf48f...1b4e4c5. Read the comment docs.

@ktmud
Copy link
Member Author

ktmud commented Jan 11, 2021

It's too much useless work. Let's leave this rule off.

@ktmud ktmud closed this Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants