Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade eslint, babel, and prettier #12393

Merged
merged 5 commits into from
Jan 11, 2021
Merged

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Jan 10, 2021

SUMMARY

Upgrade eslint, babel, and prettier related packages to the latest. Fix new lint errors:

incubator-superset/superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
  93:18  error  Arrow function used ambiguously with a conditional expression  no-confusing-arrow

incubator-superset/superset-frontend/src/dashboard/components/SliceHeaderControls.jsx
  183:28  error  Arrow function used ambiguously with a conditional expression  no-confusing-arrow

Changeset mostly comes from running npm run prettier and eslint --fix. Please select "Ignore whitespace" while reviewing: https://github.com/apache/superset/pull/12393/files?diff=unified&w=1

Lint rule react/sort-comp is temporarily disabled because there are too many offenses. Will create a separate PR to fix it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

CI

ADDITIONAL INFORMATION

@codecov-io
Copy link

codecov-io commented Jan 10, 2021

Codecov Report

Merging #12393 (8a89d70) into master (f13f2e2) will decrease coverage by 4.04%.
The diff coverage is 52.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12393      +/-   ##
==========================================
- Coverage   66.88%   62.83%   -4.05%     
==========================================
  Files        1014     1014              
  Lines       49528    49489      -39     
  Branches     5074     5073       -1     
==========================================
- Hits        33125    31095    -2030     
- Misses      16273    18184    +1911     
- Partials      130      210      +80     
Flag Coverage Δ
cypress ?
javascript 60.71% <52.08%> (+0.01%) ⬆️
python 64.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/components/ErrorMessage/types.ts 100.00% <ø> (ø)
...ntend/src/components/FacePile/FacePile.stories.tsx 0.00% <0.00%> (ø)
...rset-frontend/src/components/Icon/icon.stories.jsx 0.00% <0.00%> (ø)
...c/components/ListViewCard/ListViewCard.stories.tsx 0.00% <0.00%> (ø)
...-frontend/src/components/Select/Select.stories.tsx 0.00% <0.00%> (ø)
...ponents/Select/WindowedSelect/WindowedMenuList.tsx 10.71% <0.00%> (+0.36%) ⬆️
...frontend/src/components/SupersetResourceSelect.tsx 71.42% <0.00%> (-7.89%) ⬇️
...dashboard/components/FiltersBadge/DetailsPanel.tsx 21.42% <0.00%> (-33.12%) ⬇️
...d/src/dashboard/components/FiltersBadge/Styles.tsx 28.20% <0.00%> (-37.59%) ⬇️
...d/src/dashboard/components/SliceHeaderControls.jsx 10.71% <0.00%> (-38.07%) ⬇️
... and 231 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f13f2e2...ff3f98b. Read the comment docs.

@ktmud ktmud changed the title Upgrade eslint chore: upgrade eslint, babel, and prettier Jan 10, 2021
@ktmud ktmud force-pushed the upgrade-eslint branch 3 times, most recently from f68b68d to 8a89d70 Compare January 10, 2021 05:46
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the chore!

@ktmud ktmud merged commit 9acf48f into apache:master Jan 11, 2021
@ktmud ktmud deleted the upgrade-eslint branch January 11, 2021 01:27
@villebro villebro added the v1.0 label Jan 12, 2021
@villebro
Copy link
Member

Flagging for 1.0 to avoid cherry conflicts

@junlincc junlincc added v1.0.1 and removed v1.0 labels Jan 13, 2021
@villebro villebro added v1.0 and removed v1.0.1 labels Jan 13, 2021
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Jan 14, 2021
etr2460 pushed a commit that referenced this pull request Jan 25, 2021
* release: bump to 1.0.0 and CHANGELOG

* fix(explore): long metric name display (#12387)

* fix(explore): long metric name display

* add tooltip to control

* chore: Show datasets when search input is empty (#12391)

* chore: Fix typo “Rest” to “Reset” (#12392)

* chore: upgrade eslint, babel, and prettier (#12393)

* feat(explore): add tooltip to timepicker label (#12401)

* chore: change Datasource to Dataset in Explore ui (#12402)

* chore(explore):change dataset to datasource in ui

* modal

* Add space

* Changing it back🤦🏾‍♀️

* Chargeback

* fix: Refresh Interval Modal dropdown (#12406)

* fix(native-filters): incorrect queriesData state (#12409)

* refactor: from superset.utils.core break down date_parser (#12408)

* Fixes control panel fields styling (#12236) (#12326)

* feat: Resizable dataset and controls panels on Explore view (#12411)

* Implement resizable panels on explore view

* Optimize chart rendering while resizing

* Make dataset column narrower

Co-authored-by: Evan Rusackas <[email protected]>

* fix(dashboard): artefacts shown while drag and dropping deck.gl charts (#12418)

* [12181] Fix artifacts while drag and dropping deck.gl charts.

* Run prettier

* bump superset-ui packages for rolling window change (#12426)

* chore: bump superset-ui deckgl plugin (#12466)

* fix: do not show vertical scrollbar for charts in dashboard (#12478)

* fix: do not show vertical scrollbar for charts in dashboard

* Proper fix for #11419

Co-authored-by: Jesse Yang <[email protected]>

* fix(dashboard): use datasource id from slice metadata (#12483)

* fix(timepicker): make pyparsing thread safe (#12489)

* fix: make pyparsing thread safe

* remove parenthesis for decorator

* fix (SQL Lab): disappearing results on tab switch (#12472)

* fix (SQL Lab): disappearing results on tab switch

* Remove state

* Fix test

* fix: import ZIP files that have been modified (#12425)

* fix: import ZIP files that have been modified

* Add unit test

* update changelog with rc2 entries

* fix: impose dataset ownership check on old API (#12491)

* fix: impose dataset ownership check on old API

* update UPDATING.md

* partially protect the old MVC also

* prevent metric and column add and update

* ci: remove refs/tags from docker tags on a release (#12518)

* ci: remove refs/tags from docker tags on a release

* wider head

* fix: lowercase all columns in examples (#12530)

* fix(explore): time table control panel (#12532)

* fix(explore): Add Time section back to FilterBox (#12537)

* Fixing Pinot queries for time granularities: WEEKS/MONTHS/QUARTERS/YEARS (#12536)

* fix: Select options overflowing Save chart modal on Explore view (#12522)

* Fix select options overflowing modal

* fix unit test

Co-authored-by: Ville Brofeldt <[email protected]>

* Fix list filters vertical alignment (#12497)

* feat(db-engine): Add support for Apache Solr (#12403)

* [db engine] Add support for Apache Solr

* Fixing typo

* chore: rename docker image in build_docker_image.sh, docker-compose.yml and helm values.yaml (#12337)

* add rc3 changelog entries

* fix: Popover closes on change of dropdowns values (#12410)

* fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN (#12555)

* fix(viz): missing groupby and broken adhoc metrics for boxplot (#12556)

* fix: height on grid results (#12558)

* fix: case expression should not have double quotes (#12562)

* Fix 500 error when loading dashboards with slice having deleted dataset (#12535)

* add rc4 changelog entries

* Fixed typo on line 348

* Added files

Co-authored-by: Daniel Gaspar <[email protected]>
Co-authored-by: Yongjie Zhao <[email protected]>
Co-authored-by: Geido <[email protected]>
Co-authored-by: Junlin Chen <[email protected]>
Co-authored-by: Jesse Yang <[email protected]>
Co-authored-by: Agata Stawarz <[email protected]>
Co-authored-by: Ville Brofeldt <[email protected]>
Co-authored-by: Michael S. Molina <[email protected]>
Co-authored-by: Kamil Gabryjelski <[email protected]>
Co-authored-by: Evan Rusackas <[email protected]>
Co-authored-by: Kasia Kucharczyk <[email protected]>
Co-authored-by: Phillip Kelley-Dotson <[email protected]>
Co-authored-by: Grace Guo <[email protected]>
Co-authored-by: Beto Dealmeida <[email protected]>
Co-authored-by: Ville Brofeldt <[email protected]>
Co-authored-by: Xiang Fu <[email protected]>
Co-authored-by: Ahmed Adel <[email protected]>
Co-authored-by: Amit Miran <[email protected]>
Co-authored-by: Hugh A. Miles II <[email protected]>
Co-authored-by: Shuyao Bi <[email protected]>
Co-authored-by: Lyndsi Kay Williams <[email protected]>
@mistercrunch mistercrunch added 🍒 1.0.0 🍒 1.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels v1.0 🍒 1.0.0 🍒 1.0.1 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants