Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Refresh Interval Modal dropdown #12406

Merged
merged 2 commits into from
Jan 11, 2021

Conversation

agatapst
Copy link
Contributor

SUMMARY

In Refresh Interval modal, dropdown overflow was hidden.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
refresh_interval_dropdown_before

After:
refresh_interval_dropdown_after

TEST PLAN

Go to Dashboards and choose one. Click More button ( "3 dots" on the right) and choose Set auto-refresh interval. You will see Refresh Interval Modal. Please check if you can see all of the Refresh frequency options and choose them easily.

ADDITIONAL INFORMATION

cc @junlincc @rusackas @adam-stasiak

@junlincc
Copy link
Member

@agatapst thanks for the PR and welcome back! Can you check the tests and make sure they pass before I manually test it? 🙏

@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label Jan 11, 2021
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-io
Copy link

codecov-io commented Jan 11, 2021

Codecov Report

Merging #12406 (1338b16) into master (ff7b789) will decrease coverage by 15.90%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #12406       +/-   ##
===========================================
- Coverage   66.88%   50.98%   -15.91%     
===========================================
  Files        1014      473      -541     
  Lines       49513    16865    -32648     
  Branches     5077     4339      -738     
===========================================
- Hits        33118     8598    -24520     
+ Misses      16264     8267     -7997     
+ Partials      131        0      -131     
Flag Coverage Δ
cypress 50.98% <100.00%> (+<0.01%) ⬆️
javascript ?
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/dashboard/components/RefreshIntervalModal.tsx 63.33% <100.00%> (-23.51%) ⬇️
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx 11.76% <0.00%> (-88.24%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
superset-frontend/src/components/IconTooltip.tsx 13.33% <0.00%> (-86.67%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
...end/src/SqlLab/components/ExploreResultsButton.jsx 8.00% <0.00%> (-84.00%) ⬇️
... and 867 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7b789...1338b16. Read the comment docs.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@graceguo-supercat graceguo-supercat added dashboard:component Related to the drag&drop components of the Dashboard and removed dashboard:native-filters Related to the native filters of the Dashboard labels Jan 11, 2021
@junlincc junlincc merged commit ddbcf5b into apache:master Jan 11, 2021
@junlincc junlincc changed the title fix: Refresh Interval Modal dropdown fix(dashboard): Refresh Interval Modal dropdown Jan 11, 2021
@villebro villebro added the v1.0 label Jan 12, 2021
villebro pushed a commit that referenced this pull request Jan 12, 2021
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Jan 14, 2021
etr2460 pushed a commit that referenced this pull request Jan 25, 2021
* release: bump to 1.0.0 and CHANGELOG

* fix(explore): long metric name display (#12387)

* fix(explore): long metric name display

* add tooltip to control

* chore: Show datasets when search input is empty (#12391)

* chore: Fix typo “Rest” to “Reset” (#12392)

* chore: upgrade eslint, babel, and prettier (#12393)

* feat(explore): add tooltip to timepicker label (#12401)

* chore: change Datasource to Dataset in Explore ui (#12402)

* chore(explore):change dataset to datasource in ui

* modal

* Add space

* Changing it back🤦🏾‍♀️

* Chargeback

* fix: Refresh Interval Modal dropdown (#12406)

* fix(native-filters): incorrect queriesData state (#12409)

* refactor: from superset.utils.core break down date_parser (#12408)

* Fixes control panel fields styling (#12236) (#12326)

* feat: Resizable dataset and controls panels on Explore view (#12411)

* Implement resizable panels on explore view

* Optimize chart rendering while resizing

* Make dataset column narrower

Co-authored-by: Evan Rusackas <[email protected]>

* fix(dashboard): artefacts shown while drag and dropping deck.gl charts (#12418)

* [12181] Fix artifacts while drag and dropping deck.gl charts.

* Run prettier

* bump superset-ui packages for rolling window change (#12426)

* chore: bump superset-ui deckgl plugin (#12466)

* fix: do not show vertical scrollbar for charts in dashboard (#12478)

* fix: do not show vertical scrollbar for charts in dashboard

* Proper fix for #11419

Co-authored-by: Jesse Yang <[email protected]>

* fix(dashboard): use datasource id from slice metadata (#12483)

* fix(timepicker): make pyparsing thread safe (#12489)

* fix: make pyparsing thread safe

* remove parenthesis for decorator

* fix (SQL Lab): disappearing results on tab switch (#12472)

* fix (SQL Lab): disappearing results on tab switch

* Remove state

* Fix test

* fix: import ZIP files that have been modified (#12425)

* fix: import ZIP files that have been modified

* Add unit test

* update changelog with rc2 entries

* fix: impose dataset ownership check on old API (#12491)

* fix: impose dataset ownership check on old API

* update UPDATING.md

* partially protect the old MVC also

* prevent metric and column add and update

* ci: remove refs/tags from docker tags on a release (#12518)

* ci: remove refs/tags from docker tags on a release

* wider head

* fix: lowercase all columns in examples (#12530)

* fix(explore): time table control panel (#12532)

* fix(explore): Add Time section back to FilterBox (#12537)

* Fixing Pinot queries for time granularities: WEEKS/MONTHS/QUARTERS/YEARS (#12536)

* fix: Select options overflowing Save chart modal on Explore view (#12522)

* Fix select options overflowing modal

* fix unit test

Co-authored-by: Ville Brofeldt <[email protected]>

* Fix list filters vertical alignment (#12497)

* feat(db-engine): Add support for Apache Solr (#12403)

* [db engine] Add support for Apache Solr

* Fixing typo

* chore: rename docker image in build_docker_image.sh, docker-compose.yml and helm values.yaml (#12337)

* add rc3 changelog entries

* fix: Popover closes on change of dropdowns values (#12410)

* fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN (#12555)

* fix(viz): missing groupby and broken adhoc metrics for boxplot (#12556)

* fix: height on grid results (#12558)

* fix: case expression should not have double quotes (#12562)

* Fix 500 error when loading dashboards with slice having deleted dataset (#12535)

* add rc4 changelog entries

* Fixed typo on line 348

* Added files

Co-authored-by: Daniel Gaspar <[email protected]>
Co-authored-by: Yongjie Zhao <[email protected]>
Co-authored-by: Geido <[email protected]>
Co-authored-by: Junlin Chen <[email protected]>
Co-authored-by: Jesse Yang <[email protected]>
Co-authored-by: Agata Stawarz <[email protected]>
Co-authored-by: Ville Brofeldt <[email protected]>
Co-authored-by: Michael S. Molina <[email protected]>
Co-authored-by: Kamil Gabryjelski <[email protected]>
Co-authored-by: Evan Rusackas <[email protected]>
Co-authored-by: Kasia Kucharczyk <[email protected]>
Co-authored-by: Phillip Kelley-Dotson <[email protected]>
Co-authored-by: Grace Guo <[email protected]>
Co-authored-by: Beto Dealmeida <[email protected]>
Co-authored-by: Ville Brofeldt <[email protected]>
Co-authored-by: Xiang Fu <[email protected]>
Co-authored-by: Ahmed Adel <[email protected]>
Co-authored-by: Amit Miran <[email protected]>
Co-authored-by: Hugh A. Miles II <[email protected]>
Co-authored-by: Shuyao Bi <[email protected]>
Co-authored-by: Lyndsi Kay Williams <[email protected]>
@mistercrunch mistercrunch added 🍒 1.0.0 🍒 1.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:component Related to the drag&drop components of the Dashboard size/S v1.0 🍒 1.0.0 🍒 1.0.1 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dashboard]refresh Interval modal scroll and dropdown
7 participants