feat(ssh_tunnel): Import/Export Databases with SSHTunnel credentials #23099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #23099 +/- ##
==========================================
+ Coverage 67.54% 67.57% +0.02%
==========================================
Files 1881 1881
Lines 72396 72610 +214
Branches 7882 7910 +28
==========================================
+ Hits 48902 49067 +165
- Misses 21472 21514 +42
- Partials 2022 2029 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@Antonio-RiveroMartnez what happens when you try to import a db with ssh tunneling to an application that doesn't have the ssh tunnel feature flag turned on? |
|
@eschutho Thanks for reminding me about such check 👍 . It should reject the operation and show an error message to the user in such case. Let me add that validation and its tests. |
hughhhh
reviewed
Feb 17, 2023
superset/databases/schemas.py
Outdated
| raise SSHTunnelingNotEnabledError() | ||
| private_key = ssh_tunnel.get("private_key") | ||
| if private_key == PASSWORD_MASK: | ||
| raise ValidationError("Must provide a private key for the ssh tunnel") |
There was a problem hiding this comment.
can we add a test to make sure this will raise when the user is missing the private key
There was a problem hiding this comment.
Hey! I added a few in the api_tests and command_tests files:
https://github.com/apache/superset/pull/23099/files#diff-023d03cc917d159e443cf0e947dda5e28cfdf7c5a26c592860e1d419fc5b317eR651
https://github.com/apache/superset/pull/23099/files#diff-b94e273d2b41d3fe8a552cbf34cfa59ab9495154d16823b411470ae782cea38aR2473
Let me know if you consider we need to cover other scenarios in other places. Thanks
There was a problem hiding this comment.
After re-reading this, I'm adding some more checks, for example as you mentioned, not only raising when == PASSWORD_MASK but also checking there's at least one login method (password OR private_key + private_key_password). That way, if users manipulate files manually, we still check the integrity of the data being passed. Thanks for the insight 👍
- Add import/export API - Modify our import modals so users can enter required ssh_tunnel credentials that are not exported - Update tests and create new ones
- Add missing .length to if in the import modal - Fix comment message
- Add a check for SSH_TUNNELING feature flag, if it's disabled we should raise the already known exception informing the user - Update tests and add new tests for covering such scenario
- Add more robust checks around SSH Tunnel credentials passed in the file we want to import - Add extra exceptions so we can handle new errors and let users know - Update and add tests for new scenarios
Antonio-RiveroMartnez
force-pushed
the
ssh_tunnel_import
branch
from
d26fc64
to
e1f7f36
Compare
sebastiankruk
added a commit
to sebastiankruk/superset
that referenced
this pull request
Mar 16, 2023
* feat: add ssh tunneling to dynamic form for Database Connection UI (apache#22689) Co-authored-by: Antonio Rivero Martinez <[email protected]> Co-authored-by: Antonio Rivero <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> * chore(dashboard): Log events for download as image (apache#22793) * docs: link docker readme in docker config section (apache#22796) * chore: Add explicit bidirectional performant relationships for SQLA model (apache#22413) * fix: better logic to extract errors on databricks (apache#22792) * fix(hive): Regression in apache#21794 (apache#22794) * fix: Unexpected error on simple filter (apache#22814) * feat(docker): Build multiple python version images (apache#22770) Co-authored-by: Daniel Draper <[email protected]> * fix: allow CSV upload in Other db (apache#22807) * chore: Convert direct uses of antd icons to 'Icons' component (apache#22516) * fix(sqllab): type error on renderBigIntStr (apache#22813) * chore: upgrade react-datetime, react-intersection-observer and react-checkbox-tree (apache#22585) * feat(helm): Add ability to customize affinity per deployment (apache#22827) * chore(issue templates): discouraging Issues for feature requests (apache#22617) * docs(alerts & reports): add, prune, reorganize (apache#20872) * chore(tests): Streamline Cypress login to fix fails/flakes (apache#22844) * feat: export/import `allow_dml` flag (apache#22806) * chore: Migrate /superset/recent_activity/<user_id>/ to /api/v1/ (apache#22789) * test: Fix act errors in DatasourceControl test (apache#22845) * test: Fix act errors in DatabaseModal test (apache#22846) * feat: Move cross filters to Dashboard (apache#22785) * fix(cpq): Add `schema` to Query.data() payload (apache#22791) * fix(Annotation Layers): Error when render options with renamed columns (apache#22453) * build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.48.2 to 5.49.0 in /superset-websocket (apache#22838) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(misc): Spelling (apache#19678) Signed-off-by: Josh Soref <[email protected]> Co-authored-by: Josh Soref <[email protected]> * build(deps): bump ua-parser-js from 0.7.31 to 0.7.33 in /docs (apache#22858) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs(cache): update doc strings (apache#22865) * chore: migrate react-diff-viewer to react-diff-viewer-continued for react 18 upgrade (apache#22834) * chore: upgrade react-table for react 18 upgrade (apache#22780) * chore: upgrade react-reverse-portal for react upgrade (apache#22779) * chore: removing unnecessary double spaces, a.k.a. "shotgun holes" (apache#22852) * fix: Convert TIMESTAMP_* to TIMESTAMP in Snowflake (apache#22872) * fix(sqllab): reverts apache#22695 (apache#22861) * feat(ssh_tunnel): Add feature flag to SSH Tunnel API (apache#22805) * fix: revert RESTful apis and react view for RLS (apache#22818) * chore: deprecate /superset/slice_json/<int:slice_id> and /superset/annotation_json/<int:layer_id> (apache#22496) * chore: add statsd support to base API and refactor (apache#22887) * chore: Migrate /superset/queries/<last_updated_ms> to API v1 (apache#22611) * docs: add Skyscanner to users list (apache#22888) Co-authored-by: Calum <[email protected]> * feat: Add excel export (apache#22006) Co-authored-by: Igor Șincariov <[email protected]> Co-authored-by: EugeneTorap <[email protected]> * build(deps): bump moment from 2.29.2 to 2.29.4 in /docs (apache#22891) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump underscore from 1.12.0 to 1.12.1 in /superset-frontend (apache#22892) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: deprecate /superset/filter/... endpoint, migrate to apiv1 (apache#22882) * fix: bump isort to fix pre-commit CI (apache#22907) * chore: migrate /sql_json and /results to apiv1 (apache#22809) * chore: Localization of superset pt. 2 (apache#22772) * fix: edit pyarrow stringify to better handle emojis and accents (apache#22881) * fix(sqllab): inconsistent addNewQueryEditor behavior (apache#21999) * fix(i18n): greatly optimize Chinese translation (apache#22036) * chore: skip puppeteer chromium download (apache#22623) * fix(dependency): update cryptography import (apache#22744) Co-authored-by: Daniel Draper <[email protected]> * feat: add pyproject.toml file to project (apache#20291) * chore(db_engine_specs): clean up column spec logic and add tests (apache#22871) * feat: Adds the ECharts Sunburst chart (apache#22833) * fix: Time range filter applied on a dashboard is not persisting to the chart explore (apache#22920) * fix(fab): Fix regression on FAB dropdowns (apache#22889) * chore: migrate @vx/responsive to @visx/responsive for react 18 upgrade (apache#22815) * fix: fix warning in ssh tunnel (apache#22912) * chore: upgrade packages for react v17 upgrade (apache#22914) * chore: upgrade react-router-dom to 5.3.4 (apache#22878) * build(deps-dev): bump eslint from 8.32.0 to 8.33.0 in /superset-websocket (apache#22902) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(helm): Make Chart.AppVersion default value for image tag (apache#22854) * chore: Migrate /superset/tables/* to API v1 (apache#22501) * fix(native-filters): Ensure that time range filter loses focus after closing modal (apache#22937) * fix: Remove button is broken for metrics on Explore (apache#22940) * feat: Enable new dataset creation flow II (apache#22835) * fix(datasets): Fix property selection on JSON response (apache#22944) * fix: Improve performance of CSV download (apache#22929) * test: Clean up AdhocFilterOption test warnings (apache#22915) * chore: Bump Flask-AppBuilder constraints (apache#22927) * chore(welcome): change default last tab to "all" (apache#22798) * fix(explore): Time comparison in Mixed Chart in GENERIC_CHART_AXES not working (apache#22945) * chore(superset-ui-chart-controls): refactor pivot and rename operator (apache#22963) * build(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 in /superset-frontend (apache#22958) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(explore): unable to update linked charts (apache#22896) * chore(frontend): Spelling (apache#19676) Signed-off-by: Josh Soref <[email protected]> Signed-off-by: Josh Soref <[email protected]> Co-authored-by: Josh Soref <[email protected]> * chore: add waitress for win32 platform (apache#22935) * fix(datasets): Include expression and description in duplicated dataset columns (apache#22943) * feat: add tabs to edit dataset page (apache#22043) Co-authored-by: AAfghahi <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: lyndsiWilliams <[email protected]> * docs: add Caizin to the user list (apache#22961) * test: Fix act errors in DatabaseList test (apache#22970) * test: Clean up QueryList test warnings (apache#22972) * fix(native-filters): Don't include description icon in truncation calc (apache#22941) * fix: Prevents last temporal filter removal (apache#22982) * fix(explore): Mark time range dashboard filter with warning icon (apache#22984) * docs(alerts & reports): clarify nature of "-dev" labeled container images (apache#22988) * chore: bump python version to 3.8.16 in Dockerfile (apache#22934) * fix: Form data was not being passed to save/update slice (apache#22989) * feat(ssh_tunnel): SSH Tunnel Switch extension (apache#22967) * chore: Fix grammar (apache#22831) * docs: added Orange inside the inthewild.md doc (apache#22986) * fix: add new config to allow for specific import data urls (apache#22942) * build(deps): bump pre-commit from 2.20.0 to 3.0.4 in /requirements (apache#22996) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(explore): Save button incorrectly disabled when adding new metric with dnd (apache#23000) * build(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 in /docs (apache#22956) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: Make cte_alias a property of db engine spec (apache#22947) * fix(migrations): Flask-Migrate output is not logged during alembic migrations apache#17991 (apache#22991) * fix(dashboard): export & import chart description and certification details (apache#22471) * chore: updating link to sandbox.js (apache#23005) * fix(sqllab): clean unwanted scrollbar (apache#22990) * chore: Localization of superset pt. 3 (apache#22938) Co-authored-by: Evan Rusackas <[email protected]> * chore(deps): bump ajv and react-jsonschema-form in /superset-frontend (apache#21809) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump eslint-config-prettier from 7.2.0 to 8.6.0 in /superset-websocket (apache#22767) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 in /superset-frontend/cypress-base (apache#22955) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump @types/node from 18.11.13 to 18.11.19 in /superset-websocket (apache#22997) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(datasets): Populate Usage tab in Edit Dataset view (apache#22670) * build(deps-dev): bump @typescript-eslint/parser from 5.48.1 to 5.51.0 in /superset-websocket (apache#23013) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump typescript from 4.9.4 to 4.9.5 in /superset-websocket (apache#22933) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(tests): Cypress optimizations to help with fails (apache#23023) * chore: refactor SliceAdder for react 17 and react 18 (apache#23009) * fix(explore): Enable saving metric after changing title (apache#23020) * fix: dataset import error message (apache#23025) * fix(ssh_tunnel): Fix bug on database edition for databases with ssh tunnels (apache#23006) Co-authored-by: Lyndsi Kay Williams <[email protected]> * fix: Handles disabled options on Select All (apache#22830) * fix(dashboard): Stop updating chart owners for charts removed from dashboard (apache#21720) Co-authored-by: Michael S. Molina <[email protected]> * docs(teradata): fix connection string (apache#23051) * fix: Time Column on Generic X-axis (apache#23021) * fix: Menu items are not disappearing when deleting a dashboard (apache#23039) * fix(i18n): improve Russian translation (apache#22939) * fix(sqllab): Invalid schema fetch by deprecated value (apache#22968) * chore: Removes icon warnings from tests (apache#23054) * feat(sqllab): Add event logger (apache#23040) * chore(datasets): Refactor DatasetDAO update to leverage bulk logic for create, update, and delete operations (apache#22957) * chore: remove db_engines (apache#22444) * feat(helm): allow persisting nodePort for services (apache#22713) Signed-off-by: DASTC\gupta_rajan <[email protected]> Co-authored-by: DASTC\gupta_rajan <[email protected]> * build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.49.0 to 5.52.0 in /superset-websocket (apache#23073) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump hot-shots from 9.3.0 to 10.0.0 in /superset-websocket (apache#23031) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump prettier from 2.8.3 to 2.8.4 in /superset-websocket (apache#23030) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump @types/node from 18.11.19 to 18.13.0 in /superset-websocket (apache#23029) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: cache warmup solution non legacy charts. (apache#23012) * docs: remove duplicate navbar item (apache#22486) Signed-off-by: tison <[email protected]> * chore: Migrate get_or_create_table endpoint to api v1 (apache#22931) * chore: Migrate /superset/csv/<client_id> to API v1 (apache#22913) * fix: css template permissions for gamma role (apache#23083) * build(deps): bump ws from 8.12.0 to 8.12.1 in /superset-websocket (apache#23080) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump eslint from 8.33.0 to 8.34.0 in /superset-websocket (apache#23079) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(style): make brand icon max width customizable (apache#23081) * chore: Remove dependency warnings from SqlEditorLeftBar/index.tsx (apache#22975) * chore: Remove dependency warnings from SqlEditor/index.jsx (apache#22974) * chore: Remove dependency warnings from DatasetList.tsx (apache#22973) * test: Convert DatasetList test from jsx to tsx (apache#22971) * test: Clean up SelectAsyncControl test warnings (apache#22969) * chore: move dashboard screenshot standalone logic (apache#23003) * fix: dict bug on QueryContextFactory (apache#23093) Co-authored-by: ok9897 <[email protected]> * chore: Improve greeting message (apache#23077) * chore: Updating connection URI for MS SQL Server (apache#22903) Co-authored-by: Evan Rusackas <[email protected]> * chore: increment statsd as warn (apache#23041) * fix: removing pyproject.toml (apache#23101) * chore: change AlertQueryError to 400 (apache#23102) * fix: missing __init__ on module sqllab commands (apache#23107) * #21 preparing for linux deployment * chore(backend): Spelling (apache#19677) Signed-off-by: Josh Soref <[email protected]> Signed-off-by: Josh Soref <[email protected]> Co-authored-by: Josh Soref <[email protected]> Co-authored-by: Evan Rusackas <[email protected]> * chore: Remove yarn.lock from the root folder (apache#23108) * chore(sqla): Address performance tradeoff with eager loading (apache#23113) * fix(ci): explicity set yaml Loader (apache#23126) * fix: Validate jinja rendered query (apache#22851) * fix: reorganize role permissions (apache#23096) * fix: gamma sql_json test (apache#23135) * fix(dashboard): Chart's empty state not centered (apache#23022) * feat: Frontend tagging (apache#20876) Co-authored-by: cccs-nik <[email protected]> Co-authored-by: GITHUB_USERNAME <EMAIL> * feat: return UUID on database creation (apache#23143) * chore: Add docs for ssh tunneling (apache#23131) Co-authored-by: Beto Dealmeida <[email protected]> * feat: Enable cross fitlers in WorldMap and Graph charts (apache#22886) * chore: Bump cryptography to 39.0.1 (apache#23158) * feat(dashboard): Add cross filter from context menu (apache#23141) * chore: revert "feat(native_filter_migration): add transition mode (apache#16992)" (apache#23144) * build: Add helm chart option to deploy sidecars with node and worker (apache#23160) * fix(rbac): show objects accessible by database access perm (apache#23118) * fix: bump FAB to 4.3.0 (apache#23184) * fix(clickhouse): add clickhouse connect driver (apache#23185) * fix(clickhouse): add missing default format (apache#23192) * feat(ssh_tunnel): Import/Export Databases with SSHTunnel credentials (apache#23099) * chore: refactor SparklineCell for react 17 and react 18 upgrade (apache#23145) * fix(ssh_tunnel): Display SSHTunnel Switch when editing a DB that was created with the Dynamic Form (apache#23195) * fix(sshtunnel): argument params to properly setting `server_port` (apache#23196) * fix(ssh-tunnel): add password to `from_private_key` function (apache#23175) * fix: Pagination of VirtualTable (apache#23130) * fix(dashboard): Focusing charts and native filters from filters badge (apache#23190) * fix(docs): Change postgres to postgresql in brew install command (apache#23202) * build(deps-dev): bump @typescript-eslint/parser from 5.51.0 to 5.53.0 in /superset-websocket (apache#23133) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump @types/node from 18.13.0 to 18.14.1 in /superset-websocket (apache#23180) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test: Remove test playgrounds (apache#23203) * build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.52.0 to 5.53.0 in /superset-websocket (apache#23132) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump express and @applitools/eyes-cypress in /superset-frontend/cypress-base (apache#22342) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: fix typo (apache#23207) * feat: Cross Filters in FilterBar (apache#23138) Co-authored-by: Kamil Gabryjelski <[email protected]> * fix(dashboard): Page crashing when cross filter applied on adhoc column (apache#23215) * fix: memoized decorator memory leak (apache#23139) * build(deps-dev): bump @types/uuid from 9.0.0 to 9.0.1 in /superset-websocket (apache#23152) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump eslint from 8.34.0 to 8.35.0 in /superset-websocket (apache#23211) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: adding code owners for github actions/workflows (apache#23201) * build(deps): bump ua-parser-js from 0.7.28 to 0.7.33 in /superset-frontend (apache#22859) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump pre-commit from 3.0.4 to 3.1.0 in /requirements (apache#23168) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: add disallowed query params for engines specs (apache#23217) Co-authored-by: Ville Brofeldt <[email protected]> * chore: Add statsd logger for ssh tunneling creation (apache#23225) * fix(dashboard): Don't show cross filters checkbox to users without write permissions (apache#23237) * docs: update installation docs to include frontend asset build (apache#23199) * build(deps): bump pip-compile-multi from 2.6.1 to 2.6.2 in /requirements (apache#23122) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(dashboard): Cross-filters not working properly for new dashboards (apache#23194) * fix: refuse to start with default secret on non debug envs (apache#23186) * fix(dao): use explicit id filter (apache#23246) * fix(explore): Dashboard filters on adhoc cols not working in Explore (apache#23239) * refactor: Organizes the pages in their own folder (apache#23241) * fix: Video Game Sales dashboard default filters (apache#23242) * chore: Deprecate show_native_filters (apache#23228) * chore: Remove the ability to add filter-box charts when DASHBOARD_NATIVE_FILTERS feature is enabled (apache#23142) * fix(dashboard): Cross-filter search icon in filter bar (apache#23250) * chore(webdriver): Tuning the Webdriver logging a bit (apache#23255) * fix: customize tab on heatmap chart is blank (apache#23243) * fix(dashboard): Missing filter card styles (apache#23256) * fix: ignore ts warnings from older typescript versions (apache#23262) * chore(cache): Tuning logging in cache manager (apache#23266) * fix(dashboard): Charts crashing when cross filter on adhoc column is applied (apache#23238) Co-authored-by: Ville Brofeldt <[email protected]> * fix(plugin-chart-echarts): render horizontal categories from top (apache#23273) * feat(generic-x-axis): add x sorting on series limit metric (apache#23274) * fix(dashboard): Allow selecting text in cells in Table and PivotTable without triggering cross filters (apache#23283) * fix(migration): Address issue in apache#23228 (apache#23276) * chore(dashboard): Cleanup example dashboard filter scopes (apache#23260) * fix(dashboard): Infinite load when filter with default first value is out of scope (apache#23299) * fix(clickhouse): Update to working clickhouse-connect version (apache#23296) * chore: upgrade @ant-design/icons for react upgrade (apache#22890) * docs: typo 'admnistrators' in security.mdx (apache#23166) * build(deps-dev): bump eslint-config-prettier from 8.6.0 to 8.7.0 in /superset-websocket (apache#23292) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump @types/node from 18.14.1 to 18.14.6 in /superset-websocket (apache#23281) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump docusaurus to latest stable (apache#23317) * docs: add lost _filters param docs (apache#23316) * feat(docs): adds BugHerd to documentation site. (apache#23287) * chore: log different selenium timeout errors differently (apache#23290) * docs: improve API v1 migration documentation (apache#23298) * docs(alerts and reports): Update ExecutorType class (apache#23323) * build(deps-dev): bump @typescript-eslint/parser from 5.53.0 to 5.54.1 in /superset-websocket (apache#23294) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(dashboard): Refactor FiltersBadge (apache#23286) * chore: use util test env for init check (apache#23325) * fix(trino): normalize non-iso timestamps (apache#23339) * fix(dashboard): Cross filters with time shifted series (apache#23347) * feat(dashboard): Change default opacity of icon in FiltersBadge (apache#23350) * fix: dashboard DAO small code improvement (apache#23348) * chore: Remove Cross Filter scoping modal (apache#23216) * fix(dashboard): deepmerge htmlSchemaOverrides (apache#23329) * fix(trino): Disallow alias to source column (apache#23324) * fix(examples): Cleanup granularity_sqla column (apache#23322) * fix(sqllab): empty large query results from localStorage (apache#23302) * chore: Update pre-commit packages (apache#23173) * fix(safari): remove autocomplete in table select (apache#23361) * fix(chart-controls): Error if x_axis_sort and timeseries_limit_metric are included in main metrics (apache#23365) * feat(native-filters): allow cascading from time and numeric filters (apache#23319) * build(deps-dev): bump @types/node from 18.14.6 to 18.15.3 in /superset-websocket (apache#23360) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(native-filters): Caching scope (apache#23314) * #56 sync to fix security issues --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Josh Soref <[email protected]> Signed-off-by: Josh Soref <[email protected]> Signed-off-by: DASTC\gupta_rajan <[email protected]> Signed-off-by: tison <[email protected]> Co-authored-by: Hugh A. Miles II <[email protected]> Co-authored-by: Antonio Rivero Martinez <[email protected]> Co-authored-by: Antonio Rivero <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: JUST.in DO IT <[email protected]> Co-authored-by: ʈᵃᵢ <[email protected]> Co-authored-by: John Bodley <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Daniel Draper <[email protected]> Co-authored-by: Daniel Draper <[email protected]> Co-authored-by: Beto Dealmeida <[email protected]> Co-authored-by: Cody Leff <[email protected]> Co-authored-by: Lily Kuang <[email protected]> Co-authored-by: Sergey Shevchenko <[email protected]> Co-authored-by: Evan Rusackas <[email protected]> Co-authored-by: Sam Firke <[email protected]> Co-authored-by: Jack Fragassi <[email protected]> Co-authored-by: Geido <[email protected]> Co-authored-by: Stepan <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josh Soref <[email protected]> Co-authored-by: Josh Soref <[email protected]> Co-authored-by: Cemre Mengu <[email protected]> Co-authored-by: Mayur <[email protected]> Co-authored-by: Diego Medina <[email protected]> Co-authored-by: Daniel Vaz Gaspar <[email protected]> Co-authored-by: cleslie <[email protected]> Co-authored-by: Calum <[email protected]> Co-authored-by: Igor Șincariov <[email protected]> Co-authored-by: Igor Șincariov <[email protected]> Co-authored-by: EugeneTorap <[email protected]> Co-authored-by: Artem Shumeiko <[email protected]> Co-authored-by: 王一川 <[email protected]> Co-authored-by: nisheldo <[email protected]> Co-authored-by: Leo Schick <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Arash Afghahi <[email protected]> Co-authored-by: Denis Krivenko <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> Co-authored-by: Erik Ritter <[email protected]> Co-authored-by: Phillip Kelley-Dotson <[email protected]> Co-authored-by: lyndsiWilliams <[email protected]> Co-authored-by: tejaskatariya <[email protected]> Co-authored-by: Adrian <[email protected]> Co-authored-by: alexclavel-ocient <[email protected]> Co-authored-by: Trey Gilliland <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Rajan Gupta <[email protected]> Co-authored-by: DASTC\gupta_rajan <[email protected]> Co-authored-by: Dheeraj Jaiswal <[email protected]> Co-authored-by: tison <[email protected]> Co-authored-by: Changhoon Oh <[email protected]> Co-authored-by: ok9897 <[email protected]> Co-authored-by: kuruv <[email protected]> Co-authored-by: Zef Lin <[email protected]> Co-authored-by: cccs-RyanK <[email protected]> Co-authored-by: cccs-nik <[email protected]> Co-authored-by: mkramer5454 <[email protected]> Co-authored-by: Vivek Kumar <[email protected]> Co-authored-by: Craig Rueda <[email protected]> Co-authored-by: Geoff Genz <[email protected]> Co-authored-by: Cameron Gregor <[email protected]> Co-authored-by: Íñigo Álvaro Sáenz <[email protected]>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We are now enabling users to export databases that have SSHTunnels related to them. The exported ssh_tunnel will get included in the
databaseyamlfile and will have the used login method (passwordorprivate_key + private_key_password) with masked values.Then when user tries to import such databases (or any dashboard/chart/dataset/savedquery), the modal will ask the user to enter such credentials.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ssh_tunnelwith masked login methodssh_tunnelin itpasswordORprivate_key + private_key_password)ADDITIONAL INFORMATION