fix(dependency): update cryptography import

[Germandrummer92]

SUMMARY

• fix the cryptography import

TESTING INSTRUCTIONS

Before:

> python -m venv venv
> . venv/bin/activate
> pip install -e .
> python -c "from superset import *"
> Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/ddraper/dev/superset/superset/__init__.py", line 21, in <module>
    from superset.app import create_app
  File "/Users/ddraper/dev/superset/superset/app.py", line 23, in <module>
    from superset.initialization import SupersetAppInitializer
  File "/Users/ddraper/dev/superset/superset/initialization/__init__.py", line 32, in <module>
    from superset.extensions import (
  File "/Users/ddraper/dev/superset/superset/extensions/__init__.py", line 32, in <module>
    from superset.utils.async_query_manager import AsyncQueryManager
  File "/Users/ddraper/dev/superset/superset/utils/async_query_manager.py", line 26, in <module>
    from superset.utils.core import get_user_id
  File "/Users/ddraper/dev/superset/superset/utils/core.py", line 79, in <module>
    from cryptography.hazmat.backends.openssl.x509 import _Certificate
ModuleNotFoundError: No module named 'cryptography.hazmat.backends.openssl.x509'

after:

> python -m venv venv
> . venv/bin/activate
> pip install -e .
> python -c "from superset import *"
> 

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

closes #22743

[github-actions]

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

[EugeneTorap]

Hi @dpgaspar @villebro! Can you run CI for this PR?
cryptography==3.4.7 is released: Mar 25, 2021. Isn't it time to upgrade cryptography to 39.0.0?

[codecov]

Codecov Report

Merging #22744 (53212ed) into master (6d37e66) will increase coverage by 0.29%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #22744      +/-   ##
==========================================
+ Coverage   67.13%   67.42%   +0.29%     
==========================================
  Files        1869     1870       +1     
  Lines       71656    71832     +176     
  Branches     7822     7822              
==========================================
+ Hits        48103    48433     +330     
+ Misses      21526    21372     -154     
  Partials     2027     2027              

Flag	Coverage Δ
hive	52.72% <66.66%> (+0.12%)	⬆️
mysql	78.69% <100.00%> (+0.63%)	⬆️
postgres	?
presto	52.62% <66.66%> (+0.12%)	⬆️
python	81.90% <100.00%> (+0.53%)	⬆️
sqlite	77.08% <100.00%> (+0.58%)	⬆️
unit	51.67% <66.66%> (+0.13%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/utils/core.py	90.98% <100.00%> (+0.09%)	⬆️
superset/sql_validators/postgres.py	50.00% <0.00%> (-50.00%)	⬇️
superset/sql_validators/__init__.py	80.00% <0.00%> (-20.00%)	⬇️
superset/db_engine_specs/postgres.py	90.51% <0.00%> (-6.07%)	⬇️
superset/databases/commands/test_connection.py	90.81% <0.00%> (-3.69%)	⬇️
superset/reports/commands/log_prune.py	85.71% <0.00%> (-3.58%)	⬇️
superset/queries/api.py	97.10% <0.00%> (-2.90%)	⬇️
superset/databases/ssh_tunnel/commands/delete.py	88.88% <0.00%> (-2.78%)	⬇️
superset/databases/commands/validate_sql.py	92.00% <0.00%> (-2.00%)	⬇️
superset/databases/api.py	91.03% <0.00%> (-1.71%)	⬇️
... and 88 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[EugeneTorap]

Hi @Germandrummer92! Pls, fix Python Misc / pre-commit (3.8) CI

[Germandrummer92]

@EugeneTorap fixed black, i don't think the mypy failures are related?

[EugeneTorap]

@villebro Can you run CI again?

[EugeneTorap]

@dpgaspar @Germandrummer92 Can we upgrade cryptography to 39.0.0?
And set "cryptography>=39.0.0, <40", in setup.py

[Germandrummer92]

@EugeneTorap I ran pip-compile-multi -P cryptography thats all thats needed right?

[Germandrummer92]

nevermind, i have some weird pip-config, fixing that :)

[EugeneTorap]

And also set "cryptography>=39.0.0, <40", in setup.py in order to prevent the next major versions with breaking changes

[Germandrummer92]

should be correct now

[dpgaspar]

Please check CI errors

[EugeneTorap]

@Germandrummer92 @dpgaspar unit tests are failed because parse_ssl_cert("abc" + ssl_certificate) in test_ssl_certificate_parse don't throw an Exception in a new version of cryptography.
Should we remove this self.assertRaises() line in the unit test?

self.assertRaises(CertificateException, parse_ssl_cert, "abc" + ssl_certificate)

[Germandrummer92]

thanks for looking into it I didn't get to it yet. I removed the line in question now

[dpgaspar]

LGTM, is this ready to merge?

[dpgaspar]

strange change, prob joined the major and minor https://pypi.org/project/cryptography/#history

[EugeneTorap]

Yes