-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: harmonize and clean up list views #25961
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #25961 +/- ##
==========================================
- Coverage 69.21% 69.18% -0.03%
==========================================
Files 1941 1943 +2
Lines 75910 75902 -8
Branches 8458 8450 -8
==========================================
- Hits 52538 52510 -28
- Misses 21177 21207 +30
+ Partials 2195 2185 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
26543c2
to
b42e4f6
Compare
b42e4f6
to
1c9a9cf
Compare
e8386e2
to
a21bfe5
Compare
a21bfe5
to
4d21068
Compare
@villebro Ephemeral environment spinning up at http://34.222.153.32:8080. Credentials are |
@villebro I raised this question during the Town Hall and folks seem to be ok with removing the creator column in this PR. |
Thanks for raising this @michael-s-molina ! To strike a compromise, I introduced a "Modified by" filter to fill in for the removed "Created by" filter. I'll update the screens to reflect this and ping you for a final review once CI is green. |
/testenv up FEATURE_TAGGING_SYSTEM=True |
@villebro Ephemeral environment spinning up at http://34.222.234.40:8080. Credentials are |
/testenv up FEATURE_TAGGING_SYSTEM=True FEATURE_ALERT_REPORTS=True |
@villebro Ephemeral environment spinning up at http://35.89.27.16:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as cypress codeowner
Ephemeral environment shutdown and build artifacts deleted. |
(cherry picked from commit 0b477e3)
(cherry picked from commit 0b477e3)
SUMMARY
Currently, there is a lot of discrepancy between how list views look/work:
In addition, with the introduction of Tags, the list views have become very cluttered, raising the need for removing less relevant fields.
This makes the layout consistent across the following list views:
The following changes are made:
SCREENSHOTS
Charts
Dashboards
Dataset
Saved Queries
Row Level Security
Database
CSS Templates
Tags
Alerts & Reports
Annotation Layers
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION