Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate saveModalActions to TypeScript #28046

Merged

Conversation

EnxDev
Copy link
Contributor

@EnxDev EnxDev commented Apr 15, 2024

SUMMARY

Migrate saveModalActions to TypeScript

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A

TESTING INSTRUCTIONS

  • All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas changed the title Chore: Migrate saveModalActions to TypeScript chore: Migrate saveModalActions to TypeScript Apr 16, 2024
@EnxDev EnxDev closed this Apr 16, 2024
@EnxDev EnxDev deleted the chore/typescript-migration-saveModalActions branch April 16, 2024 07:10
@EnxDev EnxDev restored the chore/typescript-migration-saveModalActions branch April 16, 2024 07:10
@EnxDev EnxDev reopened this Apr 16, 2024
@EnxDev EnxDev closed this Apr 16, 2024
@EnxDev EnxDev reopened this Apr 16, 2024
@pull-request-size pull-request-size bot added size/XL and removed size/L labels May 2, 2024
@geido
Copy link
Member

geido commented May 3, 2024

/testenv up

Copy link
Contributor

github-actions bot commented May 3, 2024

@geido Ephemeral environment spinning up at http://52.38.63.144:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.62887% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 60.25%. Comparing base (2e5f3ed) to head (3eb0a93).
Report is 29 commits behind head on master.

Files Patch % Lines
...t-frontend/src/explore/actions/saveModalActions.ts 87.62% 7 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #28046      +/-   ##
==========================================
- Coverage   60.49%   60.25%   -0.25%     
==========================================
  Files        1931     1928       -3     
  Lines       76241    75960     -281     
  Branches     8566     8585      +19     
==========================================
- Hits        46122    45767     -355     
- Misses      28015    28084      +69     
- Partials     2104     2109       +5     
Flag Coverage Δ
hive ?
javascript 57.72% <87.62%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas rusackas requested a review from kgabryje May 3, 2024 18:28
@EnxDev EnxDev changed the title chore: Migrate saveModalActions to TypeScript refactor: Migrate saveModalActions to TypeScript May 8, 2024
@geido
Copy link
Member

geido commented May 10, 2024

/testenv up

Copy link
Contributor

@geido Ephemeral environment spinning up at http://35.166.154.194:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@geido geido merged commit 920f2f4 into apache:master May 14, 2024
30 checks passed
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

aehanno pushed a commit to kosmos-education/superset that referenced this pull request May 14, 2024
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
throw error;
}
};
export { QueryFormData };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EnxDev this is creating some warning. Do we need it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it here #28786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants