Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Removes the export of QueryFormData #28786

Merged
merged 2 commits into from
Jun 6, 2024
Merged

refactor: Removes the export of QueryFormData #28786

merged 2 commits into from
Jun 6, 2024

Conversation

EnxDev
Copy link
Contributor

@EnxDev EnxDev commented May 31, 2024

SUMMARY

Removes the export of QueryFormData

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A

TESTING INSTRUCTIONS

  • All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the explore:refactor Related to refactoring Explore label May 31, 2024
@geido geido changed the title refactor:Removes the export of QueryFormData refactor: Removes the export of QueryFormData May 31, 2024
@justinpark
Copy link
Member

This commit appears following up https://github.com/apache/superset/pull/28046/files#r1608542756

@EnxDev EnxDev mentioned this pull request Jun 4, 2024
Merged
9 tasks
@geido geido merged commit 961cb96 into apache:master Jun 6, 2024
31 checks passed
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@EnxDev @eschutho
refactor: Removes the export of QueryFormData (#28786)
4afc596
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geido geido geido approved these changes

Assignees
No one assigned
Labels
explore:refactor Related to refactoring Explore size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EnxDev @justinpark @geido