Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Removes the export of QueryFormData #28786

Merged
merged 2 commits into from
Jun 6, 2024
Merged

refactor: Removes the export of QueryFormData #28786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb8b4bf
Removes the export of QueryFormData
EnxDev May 31, 2024
94918bc
removes QueryFormData import from saveModalActions
EnxDev Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions superset-frontend/src/explore/actions/saveModalActions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import sinon from 'sinon';
import fetchMock from 'fetch-mock';
import { Dispatch } from 'redux';
import { ADD_TOAST } from 'src/components/MessageToasts/actions';
import { DatasourceType } from '@superset-ui/core';
import { DatasourceType, QueryFormData } from '@superset-ui/core';
import {
createDashboard,
createSlice,
Expand All @@ -30,7 +30,6 @@ import {
updateSlice,
getSlicePayload,
PayloadSlice,
QueryFormData,
} from './saveModalActions';

// Define test constants and mock data using imported types
Expand Down
1 change: 0 additions & 1 deletion superset-frontend/src/explore/actions/saveModalActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,4 +318,3 @@ export const getSliceDashboards =
throw error;
}
};
export { QueryFormData };
Loading