Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @superset-ui versions #7989

Merged
merged 5 commits into from
Aug 6, 2019
Merged

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Aug 5, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Bump @superset-ui packages and update SuperChart usage.
This PR branches from the initial work from @etr2460 .

TEST PLAN

Tested dashboard world bank and every chart shows up.

REVIEWERS

@etr2460

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question, otherwise lgtm

superset/assets/src/chart/ChartRenderer.jsx Outdated Show resolved Hide resolved
@kristw kristw merged commit e455f1d into apache:master Aug 6, 2019
@kristw kristw deleted the kristw--try-super-chart branch August 6, 2019 17:41
etr2460 pushed a commit to airbnb/superset-fork that referenced this pull request Aug 6, 2019
* starting

* fix: upgrade chart error

* fix: address comments

* fix: package lock

* fix: bump typescript version
etr2460 pushed a commit to airbnb/superset-fork that referenced this pull request Aug 6, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants