Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TP Remember Pagination on ag-grids #5490

Merged
merged 6 commits into from
Feb 9, 2021
Merged

TP Remember Pagination on ag-grids #5490

merged 6 commits into from
Feb 9, 2021

Conversation

shamrickus
Copy link
Member

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Visit the Servers and DS X tables and verify that they will remember your page number when navigating back.

If this is a bug fix, what versions of Traffic Control are affected?

  • master
  • 5.0.0
  • 4.1.0

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@shamrickus shamrickus changed the title Remember page TP Remember Pagination on ag-grids Feb 3, 2021
@mattjackson220 mattjackson220 added improvement The functionality exists but it could be improved in some way. Traffic Portal v1 related to Traffic Portal version 1 labels Feb 5, 2021
mattjackson220
mattjackson220 approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@mattjackson220 mattjackson220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! tested and works as expected!

@mattjackson220 mattjackson220 merged commit 68faa6e into apache:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjackson220 mattjackson220 mattjackson220 approved these changes

Assignees

@mattjackson220 mattjackson220

Labels
improvement The functionality exists but it could be improved in some way. Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TP grids should retain pagination positioning
3 participants
@shamrickus @mattjackson220 @mitchell852