-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve TP Tenant Selection #6623
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamrickus
added
improvement
The functionality exists but it could be improved in some way.
Traffic Portal v1
related to Traffic Portal version 1
labels
Mar 7, 2022
ocket8888
reviewed
Mar 7, 2022
traffic_portal/app/src/common/directives/treeSelect/tree.select.tpl.html
Outdated
Show resolved
Hide resolved
ocket8888
reviewed
Mar 17, 2022
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.d.ts
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.d.ts
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/tree.select.tpl.html
Outdated
Show resolved
Hide resolved
...ic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.Steering.tpl.html
Show resolved
Hide resolved
shamrickus
force-pushed
the
tp/tenant-select
branch
from
March 17, 2022 23:59
c8b9187
to
993107e
Compare
shamrickus
force-pushed
the
tp/tenant-select
branch
from
March 18, 2022 22:01
993107e
to
1c7a789
Compare
ocket8888
reviewed
Mar 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize that prerequisites file already had mixed indentation. I just looked near the top and saw tabs. It's still a bit messy because of that, but thank you for making it be consistent now.
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/TreeSelectDirective.js
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/tree.select.tpl.html
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/directives/treeSelect/tree.select.tpl.html
Outdated
Show resolved
Hide resolved
…yping-fixes Fix the typings
ocket8888
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
The functionality exists but it could be improved in some way.
Traffic Portal v1
related to Traffic Portal version 1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6427 and arguably #2980. It creates a new directive that can be used to display hierarchical data similar to tenants, and implements it for all tenant fields. It works as a replacement to the
select
element. I've attached some screenshots at the end.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
On each of the following pages verify that validation works, and that input actually effects the relevant tenant fields:
Tenants (Add & Edit/View)
Delivery Services (All Types, Add & Edit/View)
User (Add & Edit/View)
User Registration
Origins (Add & Edit/View).
On any page verify that the icons in the drop down are expandable/collapsable, the search box implements a basic fuzzy search, the tooltip works and is position correctly + makes sense, and verify that the input works on all supported TP resolutions.
PR submission checklist
Screenshots