Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TP Tenant Selection #6623

Merged
merged 15 commits into from
Apr 1, 2022
Merged

Conversation

shamrickus
Copy link
Member

@shamrickus shamrickus commented Mar 7, 2022

This PR fixes #6427 and arguably #2980. It creates a new directive that can be used to display hierarchical data similar to tenants, and implements it for all tenant fields. It works as a replacement to the select element. I've attached some screenshots at the end.


Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

On each of the following pages verify that validation works, and that input actually effects the relevant tenant fields:
Tenants (Add & Edit/View)
Delivery Services (All Types, Add & Edit/View)
User (Add & Edit/View)
User Registration
Origins (Add & Edit/View).

On any page verify that the icons in the drop down are expandable/collapsable, the search box implements a basic fuzzy search, the tooltip works and is position correctly + makes sense, and verify that the input works on all supported TP resolutions.

PR submission checklist

Screenshots

image
image
image

@shamrickus shamrickus added improvement The functionality exists but it could be improved in some way. Traffic Portal v1 related to Traffic Portal version 1 labels Mar 7, 2022
@ocket8888 ocket8888 self-assigned this Mar 8, 2022
Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize that prerequisites file already had mixed indentation. I just looked near the top and saw tabs. It's still a bit messy because of that, but thank you for making it be consistent now.

@ocket8888 ocket8888 merged commit b9506a3 into apache:master Apr 1, 2022
@shamrickus shamrickus deleted the tp/tenant-select branch April 1, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement The functionality exists but it could be improved in some way. Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finding correct tenant is difficult in Traffic Portal
2 participants