Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A summary of what I did (not everything was necessary):
scope.selected
set dynamically but value never readany
-typed parameter in click handlercollapseRecurse
typed asboolean | null
instead of optionalcloseSelect
of
evt
parameter ofcollapse
has implicitany
typecheckFilters
scope.$watch
callbackconst funcName = function() {...
tofunction funcName() {...
or fat-arrow functionsoh and one last thing you may not have noticed not a big deal but
TABS > SPACES I CHANGED YOUR FAKE INDENTATION TO REAL INDENTATION
USA USA USA USA
scope
used to have an implicitany
, which is why you could access things willy-nilly. Everything is now strongly typed.I couldn't get importing the namespace to work, so I quickly gave up. It's already module-scoped anyway; since you have to access it as an import the namespace doesn't do anything but get in the way imo.