Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Last Updated field to Traffic Portal #7075

Merged
merged 3 commits into from
Oct 5, 2022
Merged

Add Last Updated field to Traffic Portal #7075

merged 3 commits into from
Oct 5, 2022

Conversation

shamrickus
Copy link
Member

This PR adds the Last Updated field to every DS form in Traffic Portal (tpv2 already has them).

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Verify the last updated field is present on each type of Delivery Service and is correct in Traffic Portal.

PR submission checklist

@shamrickus shamrickus added Traffic Portal v1 related to Traffic Portal version 1 low impact affects only a small portion of a CDN, and cannot itself break one improvement The functionality exists but it could be improved in some way. low difficulty the estimated level of effort to resolve this issue is low labels Sep 19, 2022
@rimashah25
Copy link
Contributor

I see the Last Updated field in the form correctly
image
but in the DS table it shows as Invalid Date
image

mitchell852
mitchell852 reviewed Oct 4, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
rimashah25
rimashah25 approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@rimashah25 rimashah25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. On local I still see the invalid date (even for master branch). So, it seems like a local issue and not related to this PR.
Need to resolve conflicts before code can be merged.

mitchell852
mitchell852 reviewed Oct 5, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@ocket8888 ocket8888 merged commit e891995 into apache:master Oct 5, 2022
@shamrickus shamrickus deleted the tp/last-updated branch October 5, 2022 20:35
@ocket8888 ocket8888 mentioned this pull request Oct 25, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchell852 mitchell852 mitchell852 left review comments

@ocket8888 ocket8888 ocket8888 approved these changes

@rimashah25 rimashah25 rimashah25 approved these changes

Assignees

@rimashah25 rimashah25

Labels
improvement The functionality exists but it could be improved in some way. low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shamrickus @rimashah25 @mitchell852 @ocket8888