Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TP DSR edit page not rendering #7157

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Fix TP DSR edit page not rendering #7157

merged 1 commit into from
Oct 25, 2022

Conversation

ocket8888
Copy link
Contributor

Fixes a bug introduced in #7075 that prevented Delivery Service Request edit pages from rendering.

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Make sure the page renders.

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

  • This PR uses existing tests
  • This PR needs no documentation
  • This PR needs no CHANGELOG.md entry
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added Traffic Portal v1 related to Traffic Portal version 1 low impact affects only a small portion of a CDN, and cannot itself break one regression bug a bug in existing functionality introduced by a new version low difficulty the estimated level of effort to resolve this issue is low labels Oct 25, 2022
zrhoffman
zrhoffman approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this fixes the DSR edit page when lastUpdated in the JSON blob is null.

@zrhoffman zrhoffman merged commit 4ce7484 into apache:master Oct 25, 2022
@ocket8888 ocket8888 deleted the tp/fix-dsrs-view branch October 25, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zrhoffman zrhoffman zrhoffman approved these changes

Assignees
No one assigned
Labels
low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one regression bug a bug in existing functionality introduced by a new version Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ocket8888 @zrhoffman